emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Alan Ristow <alan@ristow.info>
To: Carlo Tambuatco <oraclmaster@gmail.com>,
	Bhavin Gandhi <bhavin7392@gmail.com>
Cc: Org-Mode Mailing List <emacs-orgmode@gnu.org>,
	Ihor Radchenko <yantar92@gmail.com>,
	Gustavo Barros <gusbrs.2016@gmail.com>
Subject: Re: [PATCH] Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)]
Date: Tue, 13 Jul 2021 17:35:57 +0200	[thread overview]
Message-ID: <907e39a9-75fa-a99f-7237-a754a8d795f7@ristow.info> (raw)
In-Reply-To: <C00634EE-FDF6-41DF-AA9C-FD71DBAB4A1C@gmail.com>

On 7/13/21 4:55 AM, Carlo Tambuatco wrote:
> Newbie question: what command do I use to apply the patch…?

I can tell you what worked for me. I think you probably need to have 
cloned org using git for it to work, but I am far from being a git wiz 
so there could be a workaround I don't know about in the case that you 
have it installed by a more conventional method.

First, I saved the patch file to the same directory where I have org 
cloned (for me, that is ~/.emacs.d/straight/repos/org). Then I opened a 
terminal and ran:

git apply --check 0001-Fix-duplicate-logbook-entry-for-repeated-tasks.patch

to do a dry run and make sure I had saved the patch file in the right 
place that "git apply" would run correctly. It returned nothing, which 
is good, so then I ran:

git apply --check 0001-Fix-duplicate-logbook-entry-for-repeated-tasks.patch

to apply the patch. Since I'm using straight.el as my package manager, I 
then opened Emacs and ran "M-x straight-rebuild-all".

Also, thanks to Ihor and Bhavin for your work on this. Prior to applying 
the patch, I was noticing new bizarre behavior relating to recurring 
tasks. I haven't been running the patched org very long yet, but so far, 
so good.

Finally, as a newbie here myself, I have a naïve question of my own: 
Provided the patch proves successful, how/when is it applied to the 
official org repo? Is it up to Ihor (or somebody else) to make a pull 
request, for example?

Best regards,

Alan



  reply	other threads:[~2021-07-13 15:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 13:39 Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] Gustavo Barros
2021-06-14 18:01 ` Bhavin Gandhi
2021-06-14 18:41   ` Gustavo Barros
2021-07-10 13:48   ` [PATCH] " Ihor Radchenko
2021-07-10 16:46     ` Gustavo Barros
2021-07-10 17:14     ` Bhavin Gandhi
2021-07-11  1:29       ` Ihor Radchenko
2021-07-11  5:40         ` Ihor Radchenko
2021-07-11  5:57           ` Ihor Radchenko
2021-07-12 17:50             ` Bhavin Gandhi
2021-07-13  2:55               ` [PATCH] " Carlo Tambuatco
2021-07-13 15:35                 ` Alan Ristow [this message]
2021-07-13 18:08                   ` Bhavin Gandhi
2021-07-17 13:51                   ` Ihor Radchenko
2021-07-17 13:41               ` [PATCH] " Ihor Radchenko
2021-09-25 15:25             ` Bastien
2021-09-25 18:15               ` Gustavo Barros
2021-09-26  6:26     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=907e39a9-75fa-a99f-7237-a754a8d795f7@ristow.info \
    --to=alan@ristow.info \
    --cc=bhavin7392@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=gusbrs.2016@gmail.com \
    --cc=oraclmaster@gmail.com \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).