From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Cross Subject: Re: [PATCH] Fix issue with ob-clojure not returning output Date: Mon, 6 Mar 2017 08:27:12 +1100 Message-ID: References: <87fuir7ij0.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0762762c12c4054a027109 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckdgR-0007A0-WA for emacs-orgmode@gnu.org; Sun, 05 Mar 2017 16:27:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckdgQ-0006tB-Oi for emacs-orgmode@gnu.org; Sun, 05 Mar 2017 16:27:15 -0500 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:35184) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckdgQ-0006s0-Kv for emacs-orgmode@gnu.org; Sun, 05 Mar 2017 16:27:14 -0500 Received: by mail-qk0-x22a.google.com with SMTP id v125so66438083qkh.2 for ; Sun, 05 Mar 2017 13:27:13 -0800 (PST) In-Reply-To: <87fuir7ij0.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Org-mode --94eb2c0762762c12c4054a027109 Content-Type: text/plain; charset=UTF-8 Sure. Commit message Fix incorrect argument call in ob-clojure.el org-babel-execute-clojure was calling nrepl-sync-request:eval and nrepl-request:eval with the session ID as the 3rd argument when the functions expected a clojure namespace. Replaced (cider-current-session) with (cider-current-ns). On 6 March 2017 at 04:14, Nicolas Goaziou wrote: > Hello, > > Tim Cross writes: > > > The attached patch is a simple fix for the problem with ob-clojure using > an > > incorrect cider-current-session call instead of cider-current-ns. For > > background on the issue see > > https://emacs.stackexchange.com/questions/30857/clojure- > code-evaluation-in-org-mode-produces-no-output/31169#31169 > > Thank you. > > Would you mind providing a commit message along with your patch ? > > Regards, > > -- > Nicolas Goaziou > -- regards, Tim -- Tim Cross --94eb2c0762762c12c4054a027109 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Sure. Commit message

Fix incorrect argu= ment call in ob-clojure.el

org-babel-execute-cloju= re was calling nrepl-sync-request:eval and nrepl-request:eval with the sess= ion ID as the 3rd argument when the functions expected a clojure namespace.= Replaced (cider-current-session) with (cider-current-ns).
=C2=A0=



On 6 March 2017 at 04:14, Nicolas Goaziou <m= ail@nicolasgoaziou.fr> wrote:
Hello,

Tim Cross <theophilusx@gmail.co= m> writes:

> The attached patch is a simple fix for the problem with ob-clojure usi= ng an
> incorrect cider-current-session call instead of cider-current-ns. For<= br> > background on the issue see
> https://emacs.stackexchange.com/questions/30857/clo= jure-code-evaluation-in-org-mode-produces-no-output/31169#31169

Thank you.

Would you mind providing a commit message along with your patch ?

Regards,

--
Nicolas Goaziou



--
regards,

Tim

--
Tim Cross

--94eb2c0762762c12c4054a027109--