From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id XQaEBpziAmBNLQAA0tVLHw (envelope-from ) for ; Sat, 16 Jan 2021 12:57:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OHvXAZziAmAZFAAA1q6Kng (envelope-from ) for ; Sat, 16 Jan 2021 12:57:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A8339402A7 for ; Sat, 16 Jan 2021 12:56:59 +0000 (UTC) Received: from localhost ([::1]:41092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0l8S-0000MQ-PE for larch@yhetil.org; Sat, 16 Jan 2021 07:56:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0l81-0000Ky-54 for emacs-orgmode@gnu.org; Sat, 16 Jan 2021 07:56:29 -0500 Received: from mail-ed1-f45.google.com ([209.85.208.45]:44845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0l7z-0003Bm-F7 for emacs-orgmode@gnu.org; Sat, 16 Jan 2021 07:56:28 -0500 Received: by mail-ed1-f45.google.com with SMTP id p22so12526184edu.11 for ; Sat, 16 Jan 2021 04:56:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kdd1OTri1Rd+XlrTEyOOZAlmejH/sP6dOZHkIPoKT3c=; b=Hpo5aFRTlSGpafVWoN4WHXc+zq9KQPLD0GOrODH+q4gKKU2tRBYzt3/M8wLo0zIOkG WmbEOY3TV2v4iGZskT3ktIooQyz8NNfd9yh6vjt9aCDObcZMqXDT4xaNtbyp92sRcsa1 /aHPrYkF8ThUr320L9QoJ8lXpgHC41meW2G9S+xgY1E0LQ4hlMt4U67ghLu08DQPhAYT ZTqEP13iI1hRbxiXLA1P/A8LKhghLWpZTezItcA6X3QnVtx69HjM21mq5dis7A45yWE/ K4hHXGAvRlM0C8wwvMSEpAhGzQctplZMW/YIvi2B66mL30deeYJucsLW4+PXLpPEVUSN zQfQ== X-Gm-Message-State: AOAM531yOS+/uPPreU5nWSwz7dGlkL5+i6zBNNFu6rZD5FzbHKL+/3vH u+oTMJMxY6642DApm5Rauv8bpaQ+6yFHj30rsXY= X-Google-Smtp-Source: ABdhPJwY3SxIvKWdTdFGzRmuOMyQWIHBUUQiHbDoJuY7oNaInj3xzJm2Rv3EiS+fXeIAdhqtGidl4crWKTK6Jv5jCv4= X-Received: by 2002:aa7:c151:: with SMTP id r17mr12999951edp.106.1610801785802; Sat, 16 Jan 2021 04:56:25 -0800 (PST) MIME-Version: 1.0 References: <87o8hzv1e8.fsf@gmail.com> <87lfd0v7e6.fsf@gmail.com> In-Reply-To: From: ian martins Date: Sat, 16 Jan 2021 07:56:14 -0500 Message-ID: Subject: Re: [PATCH] ob-java, a proposal on import improvement To: John Herrlin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=209.85.208.45; envelope-from=ianxm1@gmail.com; helo=mail-ed1-f45.google.com X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.76 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 3A8339402A7 X-Spam-Score: -0.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: zvBCySlL5ajE John, would you mind if I go ahead and make the change I mentioned and push it with you as the author? On Tue, Jan 12, 2021 at 7:00 AM ian martins wrote: > > On Sun, Jan 10, 2021 at 3:55 PM John Herrlin wrote: > > ian martins writes: > > > I think the problem was that I was missing static > > > imports, which you fixed in the first chunk of your patch. I don't > > > think the rest of the change is necessary. Could you revert the other > > > chunks and re-test? > > > > Thats looks correct! Thanks! > > > > Here is a patch with the regexp fix. > > That's great. One small change, though. This only allows for a single spa= ce between "import" and "static" so if someone were to put in two it wouldn= 't work. I actually did the same thing in an earlier version and it caused = a problem. Since then I went to =3D(1+ space)=3D everywhere. Could you also= move the part that you're adding down to the next line. It's not that the = line is too long, but it keeps it to one thing per line. > > The commit message is fine, but the first line shouldn't end in a period. > > ref: https://orgmode.org/worg/org-contribute.html#commit-messages