From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OCMPCSt6ml/ZawAA0tVLHw (envelope-from ) for ; Thu, 29 Oct 2020 08:15:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gD/NBCt6ml86UAAAbx9fmQ (envelope-from ) for ; Thu, 29 Oct 2020 08:15:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C52429402C2 for ; Thu, 29 Oct 2020 08:15:37 +0000 (UTC) Received: from localhost ([::1]:37328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY35s-0001G3-PY for larch@yhetil.org; Thu, 29 Oct 2020 04:15:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY33a-0008CJ-9n for emacs-orgmode@gnu.org; Thu, 29 Oct 2020 04:13:15 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:46603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kY33X-0001qd-QN for emacs-orgmode@gnu.org; Thu, 29 Oct 2020 04:13:13 -0400 Received: by mail-ed1-f66.google.com with SMTP id t11so2070760edj.13 for ; Thu, 29 Oct 2020 01:13:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SoArzHEhRGm57420IwhktWeIrTPtpaglpMFtOfi1/Zk=; b=Elep1ONRBw2YGu7O32L0UcYN+X0dQgZaH/bRHpcMMQFeaAkqREI+8v8l9kTH/zwTy7 tGO0EaOVBs+/VvZKw0QAESwz8IYDorXSPpr5Cn0mmUMp7sulKmGuURayV0SHQ4ZfHEnj vvkYrdsE4lsI964yzYHyuYA+GR5KaE/ZWWhSWZ5NG/Q7h60HHgnP5aPue/OQrZMEEVr+ on4fnjemMqQFREhh7j2mhXSvkmyWvT+cLEtNGNF0KALjgtcVvcSMQqf6e5L9GQ3LRavs JHFUEB9+yL4BsKapQjEmTqraOknJjW67GeSPTRdg//XIKM1ZK0OIipXnBwY1RJaFJFee 5rtQ== X-Gm-Message-State: AOAM53358WPoDecNASEAMXO2GfMcvG+22DjJSyzXh6X9fDzQBq1I7XaJ JJeWRLZsvucQzlGX/ALhUE3e8MvRPlgNhAsF5DU= X-Google-Smtp-Source: ABdhPJzZ6Iuxaw6PxYZnYpqZH6Y+J1fXkxciDX+/1bDVlhHps6xl0d1BlSVx+67/5LtXRnjKDHPktBO6mdmNiqlrU7Q= X-Received: by 2002:a50:fc85:: with SMTP id f5mr2792577edq.187.1603959190205; Thu, 29 Oct 2020 01:13:10 -0700 (PDT) MIME-Version: 1.0 References: <878sbpvmo0.fsf@kyleam.com> In-Reply-To: <878sbpvmo0.fsf@kyleam.com> From: ian martins Date: Thu, 29 Oct 2020 04:12:59 -0400 Message-ID: Subject: Re: [PATCH] change the ob-java default back to scripting mode To: Kyle Meyer Content-Type: multipart/alternative; boundary="000000000000c43be105b2cad98e" Received-SPF: pass client-ip=209.85.208.66; envelope-from=ianxm1@gmail.com; helo=mail-ed1-f66.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 04:13:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode mailing list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=jhu.edu (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.91 X-TUID: EXS+67WdU1Sn --000000000000c43be105b2cad98e Content-Type: text/plain; charset="UTF-8" ok I will do that. If I make the same change to dozens of tests in the same file, should I list them as separate bullets, or put the list of function names in parentheses, or is it better to omit the list if it would be long? On Wed, Oct 28, 2020 at 9:36 PM Kyle Meyer wrote: > ian martins writes: > > > Subject: [PATCH] ob-java.el: Change the default back to scripting mode > > > > * lisp/ob-java.el: Change the default to scripting mode. Add name to > > authors. > > The changelog entry should explicitly list the variables/functions that > are modified. So in this case > > * lisp/ob-java.el (org-babel-default-header-args:java): ... > > > A recent commit added functional mode and made it default, but this > > would break java source blocks for anyone that relied on the old > > default. This sets the default back to scripting mode. > > Thanks for restoring the behavior. > > > I missed a name when I put the authors of ob-C and ob-python as the > > authors of ob-java. Added it. > > Please move this unrelated change to a separate commit. > --000000000000c43be105b2cad98e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
ok I will do that.

If I make= the same change to dozens of tests in the same file, should I list them as= separate bullets, or put the list of function names in parentheses, or is = it better to omit the list if it would be long?

On Wed, Oct 28, 20= 20 at 9:36 PM Kyle Meyer <kyle@kyleam= .com> wrote:
ian martins writes:

> Subject: [PATCH] ob-java.el: Change the default back to scripting mode=
>
> * lisp/ob-java.el: Change the default to scripting mode.=C2=A0 Add nam= e to
> authors.

The changelog entry should explicitly list the variables/functions that
are modified.=C2=A0 So in this case

=C2=A0 =C2=A0 * lisp/ob-java.el (org-babel-default-header-args:java): ...
> A recent commit added functional mode and made it default, but this > would break java source blocks for anyone that relied on the old
> default.=C2=A0 This sets the default back to scripting mode.

Thanks for restoring the behavior.

> I missed a name when I put the authors of ob-C and ob-python as the > authors of ob-java.=C2=A0 Added it.

Please move this unrelated change to a separate commit.
--000000000000c43be105b2cad98e--