emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: Regression in table.el detection? [maint]
Date: Tue, 5 Jan 2021 01:36:57 -0500	[thread overview]
Message-ID: <CAFyQvY2_YD_=_jUeaG6sfS3TbMiT4pYXL1qr2tsMinyv5Fa9pQ@mail.gmail.com> (raw)
In-Reply-To: <87czyjzz6x.fsf@kyleam.com>

[-- Attachment #1: Type: text/plain, Size: 3026 bytes --]

On Tue, Jan 5, 2021 at 1:15 AM Kyle Meyer <kyle@kyleam.com> wrote:

>
>
> Exporting that table to html, I see "Before" on release_9.4.4, maint
> (273391c97), and master (00b4de329).
>
> You're able to trigger the issue with a vanilla configuration on maint?
>

Hi Kyle,

Thanks for checking. Indeed ox-html export does not show that issue.

But the weekly cron (and even local) ox-hugo exports started showing this
issue after the update to table.el table detection change that happened a
few weeks ago.

I'll investigate why only ox-hugo is showing this issue.. I am simply
calling the table.el related function from ox-html:

=====
(defun org-blackfriday-table (table contents info)
  "Transcode TABLE element into Blackfriday Markdown format.

CONTENTS is contents of the table.  INFO is a plist holding
contextual information."
  ;; (message "[ox-bf-table DBG] In contents: %s" contents)
  (if (eq (org-element-property :type table) 'table.el)
      ;; "table.el" table.  Convert it using appropriate tools.
      (let ((tbl (org-html-table--table.el-table table info)))
        (message "%S" table) ; just added this for debug
        (message "%S" tbl) ; just added this for debug
=====

and I am getting only partial table in the "tbl" variable

=====
(table (:begin 1860 :end 2062 :type table\.el :tblfm nil :contents-begin
nil :contents-end nil :value "+----------+----------+----------+
| Header 1 | Header 2 | Header 3 |
+----------+----------+----------+
| a | b | c |
+----------+----------+----------+
| d | e | f |
+----------+----------+----------+" :post-blank 1 :post-affiliated 1860
:parent (section (:begin 1703 :end 2062 :contents-begin 1703 :contents-end
2062 :post-blank 1 :post-affiliated 1703 :parent (org-data nil #2))
(special-block (:type "description" :begin 1703 :end 1783 :contents-begin
1723 :contents-end 1765 :post-blank 1 :post-affiliated 1703 :parent #2)
(paragraph (:begin 1723 :end 1765 :contents-begin 1723 :contents-end 1765
:post-blank 1 :post-affiliated 1723 :parent #3) #("Support tables written
in table.el format
" 0 42 (:parent #4)))) (paragraph (:begin 1783 :end 1860 :contents-begin
1783 :contents-end 1859 :post-blank 1 :post-affiliated 1783 :parent #2)
(verbatim (:value "ox-hugo" :begin 1783 :end 1793 :post-blank 1 :parent
#3)) #("Issue #" 0 7 (:parent #3)) (link (:type "https" :path "//
github.com/kaushalmodi/ox-hugo/issues/374" :format bracket :raw-link "
https://github.com/kaushalmodi/ox-hugo/issues/374" :application nil
:search-option nil :begin 1800 :end 1858 :contents-begin 1853 :contents-end
1856 :post-blank 0 :parent #3) #("374" 0 3 (:parent #4))) #("
" 0 1 (:parent #3))) #0)))
"<!-- This HTML table template is generated by emacs 28.0.50 -->
<table border=\"1\">
  <tr>
    <td align=\"left\" valign=\"top\">
      &nbsp;Header&nbsp;1&nbsp;
    </td>
    <td align=\"left\" valign=\"top\">
      &nbsp;Header&nbsp;2&nbsp;
    </td>
    <td align=\"left\" valign=\"top\">
      &nbsp;Header&nbsp;3&nbsp;
    </td>
  </tr>
</table>"
=====

I'll keep looking..

[-- Attachment #2: Type: text/html, Size: 4237 bytes --]

  reply	other threads:[~2021-01-05  6:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 18:47 Regression in table.el detection? [maint] Kaushal Modi
2021-01-05  6:15 ` Kyle Meyer
2021-01-05  6:36   ` Kaushal Modi [this message]
2021-01-05  6:43     ` Kaushal Modi
2021-01-05  7:19       ` Kaushal Modi
2021-01-05 17:09         ` Nicolas Goaziou
2021-01-05 17:22           ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY2_YD_=_jUeaG6sfS3TbMiT4pYXL1qr2tsMinyv5Fa9pQ@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).