[-- Attachment #1: Type: text/plain, Size: 601 bytes --] Hello, At some point in the past month or so, I have noticed that on Org master, #+author: does not set the author to empty in the exports. Simply example to reproduce: ===== #+author: Test ===== Run C-c C-e t A Expected output: ===== Table of Contents _________________ Test ===== Observed output: ===== <value of user-full-name> Table of Contents _________________ Test ===== I looked through the commits on master in the past month, but I don't see any author-specific change that would affect *all* the exporter backends. Can anyone else reproduce this issue? -- Kaushal Modi [-- Attachment #2: Type: text/html, Size: 1207 bytes --]
Am 18.05.20 um 15:57 schrieb Kaushal Modi:
> I looked through the commits on master in the past month, but I don't
> see any author-specific change that would affect *all* the exporter
> backends.
>
> Can anyone else reproduce this issue?
Same observation here (org master from about a week ago, GNU emacs 26.3,
ubuntu 18.4)
I solved the problem by using
#+author: \nbsp
and forgot to report.
Julius
Kaushal Modi writes: > At some point in the past month or so, I have noticed that on Org master, > #+author: does not set the author to empty in the exports. > > Simply example to reproduce: Thanks for the minimal example. > I looked through the commits on master in the past month, but I don't see > any author-specific change that would affect *all* the exporter backends. It bisects to b4e91b7e9 (New function: org-collect-keywords, 2020-04-26). I haven't done much digging, but I was able to restore the behavior with the change below, which may be a bad idea for other reasons. diff --git a/lisp/org.el b/lisp/org.el index 0e1e05239..a8db4c2bf 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -4501,7 +4501,6 @@ (defun org--collect-keywords-1 (keywords uniques files alist) (push (cons key value) alist) (setq keywords (remove key keywords)) (setq regexp (org-make-options-regexp keywords))) - ((not (org-string-nw-p value)) nil) ((null entry) (push (list key value) alist)) (t (push value (cdr entry))))))))))) alist)))
Hello,
Kyle Meyer <kyle@kyleam.com> writes:
> It bisects to b4e91b7e9 (New function: org-collect-keywords,
> 2020-04-26). I haven't done much digging, but I was able to restore the
> behavior with the change below, which may be a bad idea for other
> reasons.
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 0e1e05239..a8db4c2bf 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -4501,7 +4501,6 @@ (defun org--collect-keywords-1 (keywords uniques files alist)
> (push (cons key value) alist)
> (setq keywords (remove key keywords))
> (setq regexp (org-make-options-regexp keywords)))
> - ((not (org-string-nw-p value)) nil)
> ((null entry) (push (list key value) alist))
> (t (push value (cdr entry)))))))))))
At first glance, it looks harmless. If the test suite passes, we can
apply it.
Thank you.
Regards,
--
Nicolas Goaziou
[-- Attachment #1: Type: text/plain, Size: 418 bytes --] On Mon, May 18, 2020 at 7:30 PM Kyle Meyer <kyle@kyleam.com> wrote: > > It bisects to b4e91b7e9 (New function: org-collect-keywords, > 2020-04-26). I haven't done much digging, but I was able to restore the > behavior with the change below, which may be a bad idea for other > reasons. > Thanks for that bisect! If the current tests (and the new test with blank author "#+author:") pass, then we should be good :) [-- Attachment #2: Type: text/html, Size: 770 bytes --]
Nicolas Goaziou writes:
> At first glance, it looks harmless. If the test suite passes, we can
> apply it.
The test suite does pass with the change. Pushed, along with a
regression test (962b8e765).
Thanks.
[-- Attachment #1: Type: text/plain, Size: 344 bytes --] On Tue, May 19, 2020 at 8:38 PM Kyle Meyer <kyle@kyleam.com> wrote: > Nicolas Goaziou writes: > > > At first glance, it looks harmless. If the test suite passes, we can > > apply it. > > The test suite does pass with the change. Pushed, along with a > regression test (962b8e765). > Thank you for the debug and quick fix! I confirm the fix. [-- Attachment #2: Type: text/html, Size: 696 bytes --]