Org-mode mailing list
 help / color / mirror / Atom feed
From: Aaron Madlon-Kay <>
Subject: Re: [PATCH] ob-ruby.el: Don't reuse the same buffer among different named
Date: Fri, 11 Dec 2020 16:23:11 +0900
Message-ID: <> (raw)
In-Reply-To: <>

> +                                     (run-ruby-or-pop-to-buffer
> +                                      cmd (or session "ruby")
> +                                      (unless session
> +                                        (inf-ruby-buffer)))

I have just run into an issue with this: If you don't specify :ruby
then `cmd' for me is calculated by

    (cdr (assoc inf-ruby-default-implementation inf-ruby-implementations))

which gives the function `inf-ruby--irb-command' as a result.

However `run-ruby-or-pop-to-buffer' expects to get a string only.

I'm not sure if it should be org-mode's responsibility to resolve the
actual command string, or if it should be done by
`run-ruby-or-pop-to-buffer'. (It kind of seems like the latter?)

Any thoughts?


  reply	other threads:[~2020-12-11  7:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20  8:49 Aaron Madlon-Kay
2020-10-20  8:49 ` [PATCH] ob-ruby.el: allow specification of ruby command w/header arg Aaron Madlon-Kay
2020-10-24 11:39   ` Bastien
2020-10-25  1:21     ` Aaron Madlon-Kay
2020-11-10 19:34   ` Juri Linkov
2020-11-14 21:19     ` Kyle Meyer
2020-11-25 19:41       ` Juri Linkov
2020-11-27  6:42         ` [PATCH] ob-ruby.el: Don't reuse the same buffer among different named Kyle Meyer
2020-11-28 22:23           ` Kyle Meyer
2020-12-11  7:23             ` Aaron Madlon-Kay [this message]
2020-12-13  4:03               ` Kyle Meyer
2020-12-13 19:22                 ` Juri Linkov
2020-12-13 20:00                   ` Kyle Meyer
2020-12-14  0:52                     ` Aaron Madlon-Kay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Org-mode mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror list/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 list list/ \
	public-inbox-index list

Example config snippet for mirrors.
Newsgroups are available over NNTP:

AGPL code for this site: git clone