From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kb0TAXnjfF+KWAAA0tVLHw (envelope-from ) for ; Tue, 06 Oct 2020 21:36:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GEsFOHjjfF9GGQAAbx9fmQ (envelope-from ) for ; Tue, 06 Oct 2020 21:36:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4CBF29401BC for ; Tue, 6 Oct 2020 21:36:55 +0000 (UTC) Received: from localhost ([::1]:56028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPudg-0006m5-Sf for larch@yhetil.org; Tue, 06 Oct 2020 17:36:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPudF-0006lw-TP for emacs-orgmode@gnu.org; Tue, 06 Oct 2020 17:36:25 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:42579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPudE-0002UQ-8H for emacs-orgmode@gnu.org; Tue, 06 Oct 2020 17:36:25 -0400 Received: by mail-pg1-x532.google.com with SMTP id n9so43006pgf.9 for ; Tue, 06 Oct 2020 14:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=3H787SEaznDykSA0Di6ZKaLmXChaV7jQg4TIjkYSwlQ=; b=fMzPBGZlqxsJVpRTfFEeUJpLD+HDzvLAwTcC2uelz7/PxqD9XR1M1LQftipfW4014T jhoJClpThFZ+jb/0ii9uCATZIxpImqhJSXNm1DSZEQangwDp36haXIXCibyLKl4RCsEr e5xAQd+UnnpsZ3YKcaAAmiVbZ37kJjVGXh2PE9wj5Ym59lc31un0iOUob3BVWkaDSkTi Q0Uws/gK/enWY80jEjDt+IueqN1/Xc7FpbtOvMfy36DMC5vnpabeJHXy6NDfzQQYjDGk WSOFOozRAtpSWopXbh9xmZsWAsJVGA8GRXH84FSyqW79IAXiFZ/npLCPsw7+0RDlxFlb Gkfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=3H787SEaznDykSA0Di6ZKaLmXChaV7jQg4TIjkYSwlQ=; b=hiiG+xDO40W6TatVxW7yPVzy/Jl/NiyA5vACime0Dmjt9JMk4awdtD/Papb/C/vE09 /cbak0eEKfdFpyJ+sXCyQ/fxB5wgJomm9ZYRVPS3AnGBKYrAeYZYXucAuayf8uN1V7bs 7MCMAx/D0EIS5E8nAMmdA27XvTV7eKNYIEhEZOwZFUqcaquXM6F6JfotQNuJvbD20K7F /z8tfeM5WEbOS93V2bgqhP0ZJLCySM34OGV4a5NWw5k2fLFtnshtWmhVf0SpXVBAZl6k C10HvOqVORsI+vg1nfmsfw++u4U0aRu95fwgfhV2arsIOXYUEq/iO0xnWFnJkmk1uqKk rqJw== X-Gm-Message-State: AOAM532aczibuAGIplggoYnhpbNzRwbob5zoYK2Mn65Pg3LmhyJxJ/pl qDjw4JYnnT2IzTSldJVi4/M7Fa+WVHoH1DrzyaA= X-Google-Smtp-Source: ABdhPJwEc0QAbxvr/hF/QvV1++KQKr1xDqBJOgllEx4qENbdC+G0vTLD8NxC63bhoyzv1x2nFKzwc3OmJmWPM5HGPeQ= X-Received: by 2002:a65:6915:: with SMTP id s21mr160751pgq.191.1602020182224; Tue, 06 Oct 2020 14:36:22 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6a10:b642:0:0:0:0 with HTTP; Tue, 6 Oct 2020 14:36:21 -0700 (PDT) In-Reply-To: <87pn5vu0bn.fsf@nicolasgoaziou.fr> References: <86k0wiyalj.fsf@aa.i-did-not-set--mail-host-address--so-tickle-me> <87pn5vu0bn.fsf@nicolasgoaziou.fr> From: Samuel Wales Date: Tue, 6 Oct 2020 14:36:21 -0700 Message-ID: Subject: Re: Bug: (bug?) org-id-find-id-in-file doesn't close files after finding id [9.4 (9.4-7-g3eccc5-elpaplus @ ~/spacemacs/elpa/develop/org-plus-contrib-20200921/)] To: this nkk , emacs-orgmode@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=samologist@gmail.com; helo=mail-pg1-x532.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=fMzPBGZl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: y93uj0TLlySv thank you to both of you from me too. i have noticed that the same problem occurs for me with refile targets alist. putting a file there seems to open the buffer for some reason and not close it even if it had not been closed. this might require a refile or an id lookup or so. however, it does not require doing anything with that file. i frequently get org archive files sticking around. i am guessing this is due to id lookup. On 10/6/20, Nicolas Goaziou wrote: > Hello, > > this nkk writes: > >> when running org-id-find-id-in-file on an id and an unvisited file, the >> buffer it creates to visit file isn't >> closed after finding id. >> >> ** what should have happened >> I was expecting it to close the buffer if the >> file wasn't already visited by another buffer. >> >> Is this desired behavior? > > It depends. If MARKERP is non-nil, you certainly don't want to close the > newly created buffer. Otherwise, it could be closed, indeed. > > I patched master along these lines. Thank you. > > Regards, > -- > Nicolas Goaziou > > -- The Kafka Pandemic Please learn what misopathy is. https://thekafkapandemic.blogspot.com/2013/10/why-some-diseases-are-wronged.html