From: Henning Weiss <hdweiss@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-mobile agenda title
Date: Fri, 4 Jan 2013 16:29:34 +0100 [thread overview]
Message-ID: <CAKq33udVa75WmdUeeB1QsqQSzeNe=QebxVMaFBWPMvRrF27kEw@mail.gmail.com> (raw)
In-Reply-To: <87vcbjex6g.fsf@bzg.ath.cx>
[-- Attachment #1.1: Type: text/plain, Size: 847 bytes --]
Hi Bastien,
sorry for the late reply.
On Sun, Dec 30, 2012 at 9:55 AM, Bastien <bzg@altern.org> wrote:
> Hi Henning,
>
> Henning Weiss <hdweiss@gmail.com> writes:
>
> > I was wondering why this patch was reversed in master.
>
> I think the line didn't change since 4a49e40d but I might be wrong.
>
> > An updated version of the patch is attached, and a discussion of what
> > it does is below.
>
> Looks like the "updated" version is the same than the one you sent
> first:
> http://lists.gnu.org/archive/html/emacs-orgmode/2012-01/msg00938.html
>
> ... and there is an updated one in the same thread:
> http://lists.gnu.org/archive/html/emacs-orgmode/2012-01/msg01073.html
>
> Which one should I apply?
>
> Could you add a commit message with an Emacs changelog to your patch?
I have attached a better version of the patch instead.
Henning
[-- Attachment #1.2: Type: text/html, Size: 1519 bytes --]
[-- Attachment #2: 0001-Removed-match-from-agendas-title.patch --]
[-- Type: application/octet-stream, Size: 1323 bytes --]
From 50c4fb8da9cbb0debc4ccca21ba6ee248e41263c Mon Sep 17 00:00:00 2001
From: Henning Weiss <hdweiss@gmail.com>
Date: Fri, 04 Jan 2013 16:14:41 +0200
Subject: [PATCH] Removed match from agendas title
* lisp/org-mobile.el (org-mobile-sumo-agenda-command): Removed match
description from block agendas when they have a title.
This makes the generated agendas.org file more readable, as complicated block
agendas otherwise have long titles.
TINYCHANGE
---
lisp/org-mobile.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 2a083f0..b83db6a 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -598,12 +598,13 @@ The table of checksums is written to the file mobile-checksums."
(setq cnt 0)
(while (setq e (pop cmds))
(setq type (car e) match (nth 1 e) settings (nth 2 e))
+ (setq atitle (if (string= "" gdesc) match gdesc))
(setq settings (append gsettings settings))
(setq settings
(cons (list 'org-agenda-title-append
(concat "<after>KEYS=" gkey "#" (number-to-string
(setq cnt (1+ cnt)))
- " TITLE: " gdesc " " match "</after>"))
+ " TITLE: " atitle "</after>"))
settings))
(push (list type match settings) new)))))
(and new (list "X" "SUMO" (reverse new)
--
1.7.10
next prev parent reply other threads:[~2013-01-04 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 21:21 [PATCH] org-mobile agenda title Henning Weiss
2012-01-28 14:41 ` Bastien
2012-01-28 20:05 ` Henning Weiss
2012-03-20 15:30 ` Bastien
2012-12-05 13:10 ` Henning Weiss
2012-12-30 8:55 ` Bastien
2013-01-04 15:29 ` Henning Weiss [this message]
2013-01-04 16:22 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKq33udVa75WmdUeeB1QsqQSzeNe=QebxVMaFBWPMvRrF27kEw@mail.gmail.com' \
--to=hdweiss@gmail.com \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).