From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takafumi Arakaki <aka.tkf@gmail.com>
Subject: Re: [PATCH] Support hour in repeated task cookie
Date: Thu, 26 Apr 2012 16:38:24 +0200
Message-ID: <CAPM+gBRhvAcebErUbwroYGW+AhyaFpzkradkMRt2WTtSPOLCJw@mail.gmail.com>
References: <CAPM+gBR7xGraNk-9TiuDX=nyQQrMFDccJNmG8Jd_OU4x_GghcQ@mail.gmail.com>
	<CAPM+gBQyKCPn9YGvri7=hOkiFgy6XsgzrH9x8HUW75tG-HNt6g@mail.gmail.com>
	<87bomi7fwr.fsf@altern.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:56939)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <takafumi.a@gmail.com>) id 1SNPqT-0004SU-6V
	for emacs-orgmode@gnu.org; Thu, 26 Apr 2012 10:39:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <takafumi.a@gmail.com>) id 1SNPqJ-0008GB-9l
	for emacs-orgmode@gnu.org; Thu, 26 Apr 2012 10:38:56 -0400
Received: from mail-qa0-f48.google.com ([209.85.216.48]:35479)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <takafumi.a@gmail.com>) id 1SNPqJ-0008F1-38
	for emacs-orgmode@gnu.org; Thu, 26 Apr 2012 10:38:47 -0400
Received: by qady23 with SMTP id y23so498622qad.0
	for <emacs-orgmode@gnu.org>; Thu, 26 Apr 2012 07:38:44 -0700 (PDT)
In-Reply-To: <87bomi7fwr.fsf@altern.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org

Hi, Bastien

Thanks for the patch and I am sorry for this late reply (especially
because I pushed maintainers to review my patch before...).

Anyway, I tried the head of master
(580add2f4148fea949a4db5550577911ee6d756e) and it works fine for me.
But I couldn't reproduce this behavior:

> Note that timestamps need to be well formatted. =A0If there is
> a +3d repeat cookie and the original timestamp doesn have any
> indication for the hour, it will produce an error.

(BTW, you mean +3h, right?)  There is no change in the SCHEDULE time
stamp, but I've got state change log and LAST_REPEAT in PROPERTIES.
Note that I have `(setq org-log-into-drawer t)' in my configuration.
Resulting tree was something like this (I changed the state to DONE
three times):

* TODO Test
  SCHEDULED: <2012-04-26 Thu +3h>
  :LOGBOOK:
  - State "DONE"       from "TODO"        [2012-04-26 Thu 16:16]
  - State "DONE"       from "TODO"        [2012-04-26 Thu 16:16]
  - State "DONE"       from "TODO"        [2012-04-26 Thu 16:16]
  :END:
  :PROPERTIES:
  :LAST_REPEAT: [2012-04-26 Thu 16:16]
  :END:


Regarding not using constant for "dwmy".

> I didn't replace "dwmy" by a constant though, this is not expected
> to change anymore.

I think somebody may want to have minute cookie.  And in that case,
repeating the same task is tiresome.  I didn't put minute in my patch
simply because I didn't know what letter I should use.  I guess no one
wants second or century though.  So maybe we should decide what letter
to use for minute and change "dwmy" again, if you don't like the
constant solution?

--
Takafumi