From: Carsten Dominik <carsten.dominik@gmail.com>
To: Matt Lundin <mdl@imapmail.org>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Allow org-agenda-entry-types to trump org-agenda-include-deadlines
Date: Wed, 24 Mar 2010 12:08:23 +0100 [thread overview]
Message-ID: <EA92472F-3C69-4442-A152-47A0B4EDB5B3@gmail.com> (raw)
In-Reply-To: <877hp2stao.fsf@fastmail.fm>
Yes, Matt, you are right, I did not oversee that Johns patch would
conflict with our earlier one in this way. Thanks for catching this,
I have applied the fix.
- Carsten
On Mar 23, 2010, at 8:59 PM, Matt Lundin wrote:
> Hi Carsten,
>
> Commit 3a3a1023486111ef4e986de9f22e94ea9c05d890 introduced a new
> variable org-agenda-include-deadlines. In the commit,
> org-agenda-include-deadlines is set always to override
> org-agenda-entry-types (i.e., :deadline is automatically added to the
> local org-agenda-entry-types whenever org-agenda-include-deadlines is
> t).
>
> The patch below gives org-agenda-entry-types precedence over
> org-agenda-include-deadlines. AFAICT, the patch will not interfere
> with
> the behavior of org-agenda-toggle-deadlines, nor will it affect anyone
> who does not explicitly configure org-agenda-entry-types.
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 56c7256..5e057a7 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -3281,8 +3281,7 @@ given in `org-agenda-start-on-weekday'."
> (catch 'nextfile
> (org-check-agenda-file file)
> (let ((org-agenda-entry-types org-agenda-entry-types))
> - (if org-agenda-include-deadlines
> - (add-to-list 'org-agenda-entry-types :deadline)
> + (unless org-agenda-include-deadlines
> (setq org-agenda-entry-types
> (delq :deadline org-agenda-entry-types)))
> (cond
> --8<---------------cut here---------------end--------------->8---
>
> Thanks,
> Matt
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
prev parent reply other threads:[~2010-03-24 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 19:59 [PATCH] Allow org-agenda-entry-types to trump org-agenda-include-deadlines Matt Lundin
2010-03-24 11:08 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EA92472F-3C69-4442-A152-47A0B4EDB5B3@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mdl@imapmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).