From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id dkIONI9Ao19aNAAA0tVLHw (envelope-from ) for ; Thu, 05 Nov 2020 00:00:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iCVaL49Ao1+7YgAAbx9fmQ (envelope-from ) for ; Thu, 05 Nov 2020 00:00:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5DC4C940538 for ; Thu, 5 Nov 2020 00:00:13 +0000 (UTC) Received: from localhost ([::1]:46572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaShH-0007vO-DM for larch@yhetil.org; Wed, 04 Nov 2020 19:00:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaScm-0007uv-IW for emacs-orgmode@gnu.org; Wed, 04 Nov 2020 18:55:32 -0500 Received: from mail-eopbgr80111.outbound.protection.outlook.com ([40.107.8.111]:58791 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaScj-0006zF-Ub for emacs-orgmode@gnu.org; Wed, 04 Nov 2020 18:55:32 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dLUFetiUQoysK2h24is8HEpfx3o0bjh2wCY3gQgEJ/YQ+oHmoFE+7lbV7/v9vZD7FhBGtaAEcQSWnHAw20wykAZdqZkvJiqzOEb6EB6peXH8eN5ZzKqhSy3TbWc0+IjlWwc8UEz3cntepyqodxTcQDZE+YOGOo2virk8/IHhJ6Xd1nkwpv3+54Sr6UdrWc9caw3FbiteC6wAR5T8MLAwJeiW6/3IyGXKGkbRCp3oyaO3rFmLNbLjJFQTd9RMpX4yUZSh7uAd6YC+KmzfsYDk7nvIJ/sk9ZXLxOpy7kfgFvGchW5kw+ck8BWKDyD8KfiMUGA6Lvl8OPrJKaO/yQ8JuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q5uEloV/hsMTKzLw8q8mCL1pCyTuWUMyWMsfiDR2dJ8=; b=lhoKAygHolRCmz5ceDX1lE0s3e8m89iUHLw8MUnrQ/Ho7DsWYLFP2tt2hGymq8UHiqAS0USq7RmeswMEPH70RKVAgWPuWiPcPyemLKir7btJGd4nEGqanHmtQEoHkIanjWRxGoYUHJVrJ3xDW6JwEbyw2N65wWurE/JHPLQBcovkWUaRk9Cu2Z0bLzBzyRnoEZTPi1eJntYNswBYCcHB+g0MApjyQW++r1rLWa5mJVmJTktDYSE1uIpS8HWquvRXlZSEzSy8UwvW1tNOeL9m333GspF6I570oHoqk1jH63zyJ/oR3G/WFQyTva9F0uda02h5uNW+b++G1iPXt7eFAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=whil.se; dmarc=pass action=none header.from=whil.se; dkim=pass header.d=whil.se; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Wikstrom.onmicrosoft.com; s=selector2-Wikstrom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q5uEloV/hsMTKzLw8q8mCL1pCyTuWUMyWMsfiDR2dJ8=; b=T6Kk0RtR4yQhH4FXuNaBYX4UUC8GwgYbnbNrn7stVoOVqYxfjV3BC5hVzva+LOoQu4KcDga8VyEZ1nk7MJRmdJuG3YMDPgQVgLAuBNwrKxG0heebyuaj9MRVO3BD3EZr+nu/cwMfPJ08yFxZ4fQepTV1TVUiT9KmJQ2qzD4kyfw= Received: from HE1PR0202MB2857.eurprd02.prod.outlook.com (2603:10a6:3:ea::22) by HE1PR02MB3002.eurprd02.prod.outlook.com (2603:10a6:7:2b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Wed, 4 Nov 2020 23:55:24 +0000 Received: from HE1PR0202MB2857.eurprd02.prod.outlook.com ([fe80::45c5:3654:cf9f:bbc5]) by HE1PR0202MB2857.eurprd02.prod.outlook.com ([fe80::45c5:3654:cf9f:bbc5%4]) with mapi id 15.20.3499.032; Wed, 4 Nov 2020 23:55:24 +0000 From: =?iso-8859-1?Q?Gustav_Wikstr=F6m?= To: Kyle Meyer Subject: Re: Default fold state of property drawers? Thread-Topic: Default fold state of property drawers? Thread-Index: AQHWrRAhz4o2xzgdR0i+4HDQJdkDMqmt4QGAgACgqxmABRv3gIAFE1ZS Date: Wed, 4 Nov 2020 23:55:24 +0000 Message-ID: References: , <87lffl6ipm.fsf@kyleam.com> In-Reply-To: <87lffl6ipm.fsf@kyleam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [164.10.23.62] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6e36eee9-8124-4fd9-1aab-08d8811d18c3 x-ms-traffictypediagnostic: HE1PR02MB3002: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GeGUAPZi6ZOBE+5MKiRUYtuoHI2PduGbt9e4EuKqMZkOR/2nyz7X1/BbZw2AQOExYSJHGaNVv9GeOtGcs58/MItcTExluYLwnx95T8fHBV5yYp+tuYTLmzOZd6Wgat2yRPDqlAhgHpN3O/9hkgmDmCcJmI5xIZ78s/2FXk6oj8de+Z3VYJNB4ujziRqk9D4LInR23Id4fhvfJtm+GBFwP1Re+pTCGUWhWy9Hl/RDkVm5lr2Qu3CMlJ/APF4zu/stBrXtPKva5WZyqQqKaUpqLno0Z+ZeFfZwE93vxOm+46ckAyHCZF/xEgrjQ2mZhTA25enj8VXHpS5uHLMb1O6smj4H+io4ulPX+ZjUMm0hmbT7Lw/XJ7caJ04FSTMCMAzQE0w+RaiqZtF3JQAeTwAB3w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0202MB2857.eurprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(396003)(376002)(39830400003)(346002)(76116006)(55016002)(66946007)(66446008)(186003)(66476007)(66556008)(86362001)(478600001)(64756008)(52536014)(9686003)(8936002)(8676002)(5660300002)(66574015)(26005)(6506007)(2906002)(7696005)(4326008)(83380400001)(316002)(53546011)(71200400001)(33656002)(6916009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: xsLRcCQ2pvQc02Y3PMZ1rZzW8WiPbsKDSLO6qUGWPvhJjRX/AZiWFxpuI/RrPJcJ3zsBx0kDYgSQPhtXbIf2aHS01NEE2cNAOydQqCxfEYepRma00V3R4/JeKVnQTNFOyuzdP5iM7E5xAWIs9vjB98T5Z41xb+bf/aQoAIlDqzFQcfBfz6nuCJ0paqIbUBLPdPRrF2x2Dk6ey8yzv1qtllG4LvlYHaQ8ERokrLZTFnWvMomDy7xA3jOKFjzkOu4qUk9RXl7eFFDTJZ+SDcWhOUEkyC9J3F2+nrfmp4iPJzhwDrMjQmvrPT/i4bkxVVnp8Z1iFhh8JRTtEDXvzP/5w3XAFcGo0BGCNa3V3YL5Hu1U7VT3T+/TD50JLXCGCh6N46mqHl2PKM4XXMSAeALspZ00rc3DxjiE0rccJ7o7QOGJbvXEXMP2j6q8P17NSoM4dZIrSLDVchFoppmQu79yugMJNFY9I/y7sq4iYZgaPAPjAUvUdDSLS9KyjABmXEGHnJethd0QqerVgE2s+UTcYlJr9n4Eaa8lwP8qQPQ2YRMiPVKdtdef/fHpoLYnCmZMQNe8IzjIl33Uik7cNPn3B96/v+teSw3lElm0Tjx2OaGNM07FzNIS7jrDvAB0jeGteYrSWtagiFqAr6ENKpBdhg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: whil.se X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HE1PR0202MB2857.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e36eee9-8124-4fd9-1aab-08d8811d18c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2020 23:55:24.1089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f6cdb11-323f-43c4-adf3-a2c5097674cd X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o2utx5C9d1xvzlKoSl04/POOeh/qNQVuxiVXSNskNAr5CVvcKOHEwoafyx43ApO1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR02MB3002 Received-SPF: pass client-ip=40.107.8.111; envelope-from=gustav@whil.se; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/04 18:55:26 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "emacs-orgmode@gnu.org" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=Wikstrom.onmicrosoft.com header.s=selector2-Wikstrom-onmicrosoft-com header.b=T6Kk0RtR; arc=pass (microsoft.com:s=arcselector9901:i=1); dmarc=temperror reason="server fail" header.from=whil.se (policy=temperror); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: XUYeAZxi1rkC Hi Kyle,=0A= =0A= And thanks for a second pair of eyes on this!=0A= =0A= I've pushed a patch to the repo that should fix it.=0A= =0A= --- commit 8d7a9b4ce=0A= Hide drawers before first headline properly when cycling visibility=0A= =0A= * lisp/org.el (org--hide-drawers): New internal function consolidating=0A= logic from two places currently.=0A= =0A= (org-cycle-hide-drawers): Hide drawers before first headline at=0A= appropriate times. Refactor to use new internal function=0A= `org--hide-drawers'.=0A= =0A= (org-hide-drawer-all): Refactor to use new internal function=0A= `org--hide-drawers'.=0A= =0A= Kind regards=0A= Gustav=0A= =0A= ________________________________________=0A= From: Kyle Meyer =0A= Sent: Sunday, November 1, 2020 19:21=0A= To: Gustav Wikstr=F6m=0A= Cc: emacs-orgmode@gnu.org=0A= Subject: Re: Default fold state of property drawers?=0A= =0A= Gustav Wikstr=F6m writes:=0A= =0A= > But maybe my issue rather lies in how the visibility toggling with=0A= > S-TAB functions. The file property drawer is open in OVERVIEW and=0A= > CONTENT but hidden in SHOW ALL. My intuition says that the=0A= > file-property drawer should be closed for all toggle-states. Thoughts?=0A= =0A= I agree. While I've never used file-level property drawers, my=0A= expectation would be for them to behave in the same way a heading's=0A= would.=0A= =0A= FWIW when you introduced file-level property drawers in 1bdff9f73 (Org=0A= document property-drawers, 2019-05-26), it looks like cycling wasn't=0A= considered and S-TAB would just ignore these drawers, preserving their=0A= current state.=0A= =0A= The cycling behavior you described above appears to come with 1aa095ccf=0A= (Fix drawer invisibility, 2020-06-06). I think that was in response to=0A= . While I=0A= haven't taken a close look, my guess is that the effect on file-level=0A= property drawers was unintended, and that improvements here would be=0A= welcomed.=0A=