From: Emily Bourke <email@example.com> To: Kyle Meyer <firstname.lastname@example.org> Cc: "email@example.com" <firstname.lastname@example.org> Subject: Re: [PATCH] ox-publish.el: Speed up org-publish-cache-file-needs-publishing Date: Wed, 06 Jan 2021 20:58:56 +0000 Message-ID: <J1sBspsasXyFOFV3343q4ncANvrd2CE0dVJExZZseZdLsM3gKcFenmfjb-Xix30RbgoU2te7WczcNPWyK2Md75V_ponyXWV-uhR3InFKTboemail@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Thanks for the feedback! > Nothing jumps out to me. For large files that are already visited, I > suppose find-file-noselect returning an existing buffer can be faster, > so relevant factors would include how many Org files a project has, how > large they are, and how many of those are visited in the current > session. My guess is that using with-temp-buffer and > insert-file-contents would be a net gain, though that gain would be > narrowed some if the temporary buffer was put into org-mode rather than > kept in fundamental-mode (more below). I'll do some testing with some large org files and see how things compare – it might be worth switching to the buffer for the file if there is one already. > This reads to me like after-find-file is the hook itself. Perhaps > something like this would be clearer: "... avoids calling > after-find-file and running find-file-hook, ...". Ah yes, I had misunderstood – I'll rephrase it. > The goto-char call can be dropped now because insert-file-contents inserts > after point. I follow, will remove. > Unlike the previous code, this doesn't activate org-mode in the buffer. > That gives a speedup. And I don't spot any code downstream that depends > on the major mode being org-mode, so it's probably safe, though perhaps > there's a subtle change in behavior here (e.g., related to syntax > table). > > If org-mode isn't called, the org-inhibit-startup binding above could be > dropped. Yeah, if you're worried about it I could try manually activating org mode in the temp buffer – I'm not confident I could predict any problems there might be from not activating it. > This introduces a regression. With the previous code, the > find-file-noselect call led to default-directory being set to the Org > file's directory, and then this expand-file call on the included file > was relative to that. With the new code, default-directory isn't > changed, so it points to a non-existing or incorrect file unless the > current default-directory and the Org file's happen to match. Ah, I hadn't noticed this – I'll change it to set default-directory manually.
next prev parent reply other threads:[~2021-01-06 20:59 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-01 19:58 Emily Bourke 2021-01-04 3:28 ` Kyle Meyer 2021-01-06 20:58 ` Emily Bourke [this message] 2021-01-07 1:11 ` Dr. Arne Babenhauserheide
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://orgmode.org * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='J1sBspsasXyFOFV3343q4ncANvrd2CE0dVJExZZseZdLsM3gKcFenmfjb-Xix30RbgoU2te7WczcNPWyK2Md75V_ponyXWV-uhR3InFKTboemail@example.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Org-mode mailing list This inbox may be cloned and mirrored by anyone: git clone --mirror https://orgmode.org/list/0 list/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 list list/ https://orgmode.org/list \ email@example.com public-inbox-index list Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.yhetil.org/yhetil.emacs.orgmode nntp://news.gmane.io/gmane.emacs.orgmode AGPL code for this site: git clone https://public-inbox.org/public-inbox.git