From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8PyrDLwiqV/lVQAA0tVLHw (envelope-from ) for ; Mon, 09 Nov 2020 11:06:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cJ2KCLwiqV+TAwAA1q6Kng (envelope-from ) for ; Mon, 09 Nov 2020 11:06:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9327B9404E0 for ; Mon, 9 Nov 2020 11:06:35 +0000 (UTC) Received: from localhost ([::1]:33352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc50K-0008LB-JG for larch@yhetil.org; Mon, 09 Nov 2020 06:06:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc4zT-0008FB-PT for emacs-orgmode@gnu.org; Mon, 09 Nov 2020 06:05:41 -0500 Received: from static.rcdrun.com ([95.85.24.50]:48725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc4zS-0005gU-AW for emacs-orgmode@gnu.org; Mon, 09 Nov 2020 06:05:39 -0500 Received: from localhost ([::ffff:197.157.34.177]) (AUTH: PLAIN admin, TLS: TLS1.2,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by static.rcdrun.com with ESMTPSA id 00000000002C0004.000000005FA92280.0000229B; Mon, 09 Nov 2020 11:05:32 +0000 Date: Mon, 9 Nov 2020 09:14:24 +0300 From: Jean Louis To: stardiviner Subject: Re: [PATCH] add new link type "contact:" for org-contacts.el Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0 (3d08634) (2020-11-07) Received-SPF: pass client-ip=95.85.24.50; envelope-from=bugs@gnu.support; helo=static.rcdrun.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 06:05:19 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julien@danjou.info, Org-mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: xJMe4q69xMlr * stardiviner [2020-11-09 03:25]: > After waited some days, still no reponse, so I popup this email. > Can some Org maintainer review my patch? Thanks. > It does not changed org-contacts.el core logic. Just added a new link type. > Should be easy to review. If I may say, many people manage their contacts and it can be by various ways, I am managing my contacts and by default use "contact:" I find it useful for people to leave "contact:" link free and not bind it to org-contact package. Instead it is more pointful to make "org-contact:" link that specificaly points to contacts for org-contact package. Just "org-contact:" instead of "contact:"