From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oFxVCFETB2DYXwAA0tVLHw (envelope-from ) for ; Tue, 19 Jan 2021 17:13:53 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yFMhBFETB2BmCwAAB5/wlQ (envelope-from ) for ; Tue, 19 Jan 2021 17:13:53 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9AD48940484 for ; Tue, 19 Jan 2021 17:13:52 +0000 (UTC) Received: from localhost ([::1]:59856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1uZi-0001pK-4O for larch@yhetil.org; Tue, 19 Jan 2021 12:13:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1uNF-0007N0-LW for emacs-orgmode@gnu.org; Tue, 19 Jan 2021 12:01:02 -0500 Received: from ciao.gmane.io ([116.202.254.214]:54608) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1uND-0002xv-Ka for emacs-orgmode@gnu.org; Tue, 19 Jan 2021 12:00:57 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1l1uN7-0004tS-5e for emacs-orgmode@gnu.org; Tue, 19 Jan 2021 18:00:49 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file Date: Wed, 20 Jan 2021 00:00:42 +0700 Message-ID: References: <87ftazz9q0.fsf@gmail.com> <87lfho7ja2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------7EC12D0BE528CD60E9CF74B3" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 29 X-Spam_score: 2.9 X-Spam_bar: ++ X-Spam_report: (2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.75 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 9AD48940484 X-Spam-Score: -1.75 X-Migadu-Scanner: scn1.migadu.com X-TUID: gdd6ZuvoKW8L This is a multi-part message in MIME format. --------------7EC12D0BE528CD60E9CF74B3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 19/01/2021 08:53, Christopher Miles wrote: > > For this problem, do you have any workable solution patch? Maybe for a while it is better to avoid xdg-open or other handlers that launch actual viewers in background. E.g. to replace xdg-open with actual handlers in mailcap. I attach a draft patch that just demonstrates my intention to use make-process. It intentionally does not use shell to run the command and such change could be breaking for some part of users. I have not tested if regexp substitutions for org-file-apps entries are not broken. In kubuntu-18.04 I do not have any xdg-open entries in the system mailcap file. Even if I add such line to the user's file, I could not reproduce the problem with any of the real handler configured for the image/png type and launched by xdg-open: geeqie, gwenview, feh. I have no idea concerning the reason: older xdg-open version, other code working in xdg-open for kde desktop, or limited resources allocated to qemu virtual machine with ubuntu-20.04 where I can reproduce the problem. --------------7EC12D0BE528CD60E9CF74B3 Content-Type: text/x-patch; charset=UTF-8; name="org-open-file-make-process.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="org-open-file-make-process.patch" diff --git a/lisp/org.el b/lisp/org.el index 5b1443c4e..299f39949 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -8743,29 +8743,34 @@ If the file does not exist, throw an error." (cond ((and (stringp cmd) (not (string-match "^\\s-*$" cmd))) ;; Remove quotes around the file name - we'll use shell-quote-argument. - (while (string-match "['\"]%s['\"]" cmd) - (setq cmd (replace-match "%s" t t cmd))) - (setq cmd (replace-regexp-in-string - "%s" - (shell-quote-argument (convert-standard-filename file)) - cmd - nil t)) - - ;; Replace "%1", "%2" etc. in command with group matches from regex - (save-match-data - (let ((match-index 1) - (number-of-groups (- (/ (length link-match-data) 2) 1))) - (set-match-data link-match-data) - (while (<= match-index number-of-groups) - (let ((regex (concat "%" (number-to-string match-index))) - (replace-with (match-string match-index dlink))) - (while (string-match regex cmd) - (setq cmd (replace-match replace-with t t cmd)))) - (setq match-index (+ match-index 1))))) - - (save-window-excursion - (message "Running %s...done" cmd) - (start-process-shell-command cmd nil cmd) + (let* ((command (split-string-and-unquote cmd)) + (command (mapcar (lambda (arg) + (while (string-match "['\"]%s['\"]" arg) + (setq arg (replace-match "%s" t t arg))) + arg) + command))) + ;; Replace "%1", "%2" etc. in command with group matches from regex + (save-match-data + (let ((match-index 1) + (number-of-groups (- (/ (length link-match-data) 2) 1))) + (set-match-data link-match-data) + (while (<= match-index number-of-groups) + (let ((regex (concat "%" (number-to-string match-index))) + (replace-with (match-string match-index dlink))) + (setq command + (mapcar (lambda (arg) + (while (string-match regex arg) + (setq arg (replace-match replace-with t t arg))) + arg) + command))) + (setq match-index (+ match-index 1))))) + (setq command (mapcar (lambda (arg) (format-spec arg (list (cons ?s file)))) command)) + (save-window-excursion + (message "Running %S...done" command) + (make-process :name "org-open-file" :connection-type 'pipe + :buffer "*Messages*" + :filter (lambda (proc string) (message "org-open-file: %s" string)) + :noquery 't :command command)) (and (boundp 'org-wait) (numberp org-wait) (sit-for org-wait)))) ((or (stringp cmd) (eq cmd 'emacs)) --------------7EC12D0BE528CD60E9CF74B3--