Org-mode mailing list
 help / color / mirror / Atom feed
From: Maxim Nikulin <>
Subject: Re: bug processing non emacs-lisp blocks
Date: Thu, 29 Jul 2021 21:54:03 +0700
Message-ID: <sdufed$g9s$> (raw)
In-Reply-To: <>

On 29/07/2021 11:13, Tim Cross wrote:
> dmg writes:
>> org-babel-load-file will try to tangle any source block that contains
>> the substring emacs-lisp or elisp in their language.
>> For example, the following code block will be tangled:
>> #+begin_src emacs-lispDONOT
>> (use-package "org-sidebar")
>> #+end_src
>> I think this is a regression. I used to comment out blocks from my
>> .org init files by simply adding a XXX (as in emacs-lispXXXX). In
>> current org these blocks are tangled :(
> I think your right. The regexp should only match on complete string.

I agree as well. Related code changed in 9.4:

The following is just my opinion, not a request for an update of the patch.

Maybe it will be better to change `org-babel-tangle-collect-blocks' 
function in lisp/ob-tangle.el instead and to wrap passed argument in the 
suggested way (at first I thought of non-capturing group "\\(?:" "\\)", 
but it is not necessary since the regexp is passed to `string-match-p'). 
I suppose, it is more reliable default. If anyone really needs partial 
match, he may express it explicitly by adding ".*", "?", etc. I hope, 
such change will break no existing code.

  reply	other threads:[~2021-07-29 14:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  3:37 dmg
2021-07-29  4:13 ` Tim Cross
2021-07-29 14:54   ` Maxim Nikulin [this message]
2021-08-07 20:24 ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='sdufed$g9s$' \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Org-mode mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror list/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 list list/ \
	public-inbox-index list

Example config snippet for mirrors.
Newsgroups are available over NNTP:

AGPL code for this site: git clone