From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id QO8XJzHULGZlqgAAqHPOHw:P1 (envelope-from ) for ; Sat, 27 Apr 2024 12:32:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QO8XJzHULGZlqgAAqHPOHw (envelope-from ) for ; Sat, 27 Apr 2024 12:32:17 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714213937; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=PTE92Tm6pl3+NXRcFp9+zOaMPZEwg9n7Cvrkw4JdARc=; b=a9nJpsU7cjNZo6GUMK4aMSVf9NIcuUsNjSsxFdJ8XOMRghn4/W+VUVbtqrfxdAGOjWgWlq 0oVLnIGJ0BZ4/6tvohxtxZazzdKphkJx8ird8ojtDqtxv6+Dw3XHKIJxLpseF5svB7Y3vF CUwBqYo44eyue27SRqRJ/ZKaXMv+przwg/W1K9TO90/OfCFEH5ZYe015n5ZMWaQVyCcq4e Xop9uTP5IyDIk+SYoUJvXhY5kjkw41QpFv4Hi5gVtSDpRxbavFVE0eND8ynp79Sf6asmxg iOTYM6Ojab3tP5VKQMQIU6vInGH+OwWHwK5PAB9j4NBe/DViNocertmgmuOWIA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714213937; a=rsa-sha256; cv=none; b=cvf12Vydoz/d1lQAADRJyLGQ+L/KKFbZpbrJEPU8B6KhIwGAyOcRvzN/1pGaYKR5r1/Dwm Qczaj28S2DilH8nUb/mYDugrcBy8i+qHi22oFZU6hxIL8ZZgQNvzOXG/IPRM+CLDgKh13i 1oIAAA7l0R+8pi7FZpAtQcI2zRny3vrgupNu1KIkQe/nZ+XLz0qn1RdGHKtkmnNtfaPXYE qYe/8IfLN5xhq0n3Jo4RNa/aCeLyDqDhqk+cKa25gzqX0R0OVu7+30pC8Wj0p7RlNiLLjC 7oY1ybvgdLAzel7uyStJlvf4t7zh6FEaZ5JX9VuIToDSC8hVqXm9FZFLEN1hsg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 55EB5166C8 for ; Sat, 27 Apr 2024 12:32:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0fL1-0004gG-8k; Sat, 27 Apr 2024 06:31:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0fKz-0004de-8b for emacs-orgmode@gnu.org; Sat, 27 Apr 2024 06:31:21 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0fKx-0000JF-Fj for emacs-orgmode@gnu.org; Sat, 27 Apr 2024 06:31:20 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1s0fKv-0004zv-8j for emacs-orgmode@gnu.org; Sat, 27 Apr 2024 12:31:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Re: [BUG] ob-shell: :shebang changes interpretation of :cmdline Date: Sat, 27 Apr 2024 17:31:07 +0700 Message-ID: References: <18f01342a2f.124ad27612732529.8693431365849276517@excalamus.com> <878r14qso9.fsf@localhost> <87a5liexcu.fsf@localhost> <87le50uyx4.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US, ru-RU In-Reply-To: <87le50uyx4.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.89 X-Spam-Score: -0.89 X-Migadu-Queue-Id: 55EB5166C8 X-Migadu-Scanner: mx13.migadu.com X-TUID: KrJm9jWstdyq On 26/04/2024 18:49, Ihor Radchenko wrote: >> >>>> + shell-file-name >>> ... >>>> + (list shell-command-switch >>>> + (concat (file-local-name script-file) " " cmdline)))) >> Max Nikulin writes: >>> Using `shell-command-switch' unconditionally may lead to executing >>> /bin/sh instead of shell specified by `shell-file-name' for script files >>> having no shebang, see >>> >>> https://superuser.com/questions/502984/writing-shell-scripts-that-will-run-on-any-shell-using-multiple-shebang-lines > > I conclude that your concern, while being valid, is a _different_ bug. > Thus, I do not see it as a blocker for my patch - my patch will fix the > *original bug reported on top of this thread*. My concern is that your patch trying to fix one bug (I am not convinced it is an improvement despite it is a step toward consistency) introduces another one that is not currently present in the code. > (with-temp-file script-file > (if shebang (insert shebang "\n") > (insert "#!" shell-file-name "\n")) > (when padline (insert "\n")) > (insert body)) This code has an issue. Interpretation of relative file names in shebangs varies across shells. If you insist on parsing :cmdline by shell (I do not like it) then you may try ' '