From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id GAQ+LfNVO2aoFAAAe85BDQ:P1 (envelope-from ) for ; Wed, 08 May 2024 12:37:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id GAQ+LfNVO2aoFAAAe85BDQ (envelope-from ) for ; Wed, 08 May 2024 12:37:39 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715164659; a=rsa-sha256; cv=none; b=cou7cleQf+SLE3D9k49MfIaF59b7REl9SGRaXtL5GZLe19jzIgDxJL5PmJ9QwVyCGxxsmo eSuPeJ95l9HakQI/ONpUHmDjd8mbEqqssoIrAq2BkBx3PWXYlqCtoPjA4mmM5eKv19COGt AXDxU/JsYzmjtG+eLWB75p4L539WDRPKZQBfv6Bg3HKVtFB+ufvURQjqNehWYGxkvWbixs x1IsE/eGaNpyHBChUAwXq2GmXoTMNzeKOM6BAS8oJWmhXKoPV+/sEup4Da/ot/ebXqHoYn vsSik2EhQb7arX+j4tn/SRoLx25gZfUTch/ShUqegMAWPk/pA+OMRUwlI+A+6Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715164659; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OO/UEeUqxTQW8OWJdQKT5gc3eJoHAA4bfCpQOWGXQ98=; b=a8a2AgphRpTUXEtvg2nS8e6WVR8Lm/bkuEVaG+Pah4U4TskybE5BkvJFoiz0C4M21NZLF6 Ph6D0Pii1EuyQD7Lvsl2oLpK7Oj12EnlWUaB9FlB3/dHKhwztyILGsvayQHcRI5jUNoh/z 8Ssykl4PcJX9Ad7k1zR8hHroaMe1zgwTC8iw+MilRWDlpGL4H3jmMzzXlITHmwfdi/fV3Q QnM6S5DMHdsivyUbC3/olOMCxhHn4umjuNXNH4auKvb6CKO7bW3hYiGXBIJdK9FzIXf6CK VDzgjVcOY/8MoRsirP9rox5kp0NptJtgfJr4w/TRx2uQJTk62Q5hk+cfwzFdZg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8362A311BA for ; Wed, 8 May 2024 12:37:39 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4eey-0000r3-4H; Wed, 08 May 2024 06:36:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4eeo-0000pf-OC for emacs-orgmode@gnu.org; Wed, 08 May 2024 06:36:20 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4een-00066y-8O for emacs-orgmode@gnu.org; Wed, 08 May 2024 06:36:18 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1s4eel-0005t8-9l for emacs-orgmode@gnu.org; Wed, 08 May 2024 12:36:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] Fix regex for determining image width from attribute Date: Wed, 8 May 2024 17:36:08 +0700 Message-ID: References: <87czmtuy0p.fsf@gmail.com> <87a6hxuw0y.fsf@gmail.com> <877dd07fnb.fsf@gmail.com> <8735noqig0.fsf@gmail.com> <87wnl05ag6.fsf@gmail.com> <87y25fq5d2.fsf@gmail.com> <8735nnlaef.fsf@gmail.com> <87v90jph1w.fsf@gmail.com> <871r37l96a.fsf@gmail.com> <87k0gzpb5s.fsf@gmail.com> <87h7c2pb6w.fsf@gmail.com> <87ee75pmsn.fsf@gmail.com> <87czmjajyx.fsf@gmail.com> <87k0grk0ge.fsf@gmail.com> <87ee6x3t39.fsf@gmail.com> <87zgpkq5a5.fsf@gmail.com> <871r2ucuhz.fsf@gmail.com> <87cyq49o01.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US, ru-RU In-Reply-To: <87cyq49o01.fsf@localhost> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 26 X-Spam_score: 2.6 X-Spam_bar: ++ X-Spam_report: (2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 8362A311BA X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 1.17 X-Spam-Score: 1.17 X-TUID: 56jii77fBKsC On 02/05/2024 23:28, Ihor Radchenko wrote: > 1. #+attr_org is prioritised I ma afraid, the code is a bit fragile. Consider #+attr_html: :alt Image width test #+attr_beamer: :width \linewidth #+attr_latex: :width +.5\textwidth #+attr_md: :width 75% [[file:babelfish.png]] - I do not mind that just "\linewidth" is ignored. - The case of "+.5" should either be supported or at least documented since it is a valid floating number. - It is really confusing that #+attr_html casts shadow on #+attr_md. > +++ b/etc/ORG-NEWS > @@ -13,6 +13,18 @@ Please send Org bug reports to mailto:emacs-orgmode@gnu.org. > > * Version 9.7 (not released yet) > ** Important announcements and breaking changes > +*** Inline image width value in =#+attr_org= is preferred over other =#+attr_...= keywords > + > +Previously, when ~org-image-actual-width~ is a list, Org used the > +first =#+attr_...= keyword containing =:width ...= to compute the inline > +image width: > + > +: #+attr_html: :width 30% > +: #+attr_org: :width is ignored > +: [[image.png]] > + > +Now, =#+attr_org=, if present, takes precedence. I think, it is better to avoid "is ignored" here. Previously, when ~org-image-actual-width~ is a list or nil, Org used the first =#+attr_...= keyword containing =:width ...= to compute the inline image width. Now, =#+attr_org=, if present, takes precedence. In the following example the image preview has width of 70% while earlier versions take 33%. : #+attr_html: :width 33% : #+attr_org: :width 0.7 : [[image.png]]