emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric S Fraga <e.fraga@ucl.ac.uk>
To: emacs-orgmode@gnu.org
Subject: [bug] alias for list-diary-entries-hook creates loop in emacs 24
Date: Wed, 11 Jan 2012 08:56:56 +0000	[thread overview]
Message-ID: <874nw262hz.fsf@ucl.ac.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Hello,

one of the recent updates

  commit d6e40fb3472761ed51795f54491b969976167116
  
to org has caused a problem with the latest emacs snapshot (version from
5 January I believe).  Specifically, the alias for
list-diary-entries-hook would appear to create an alias loop as
diary-lib.el in emacs already has an alias.

Removing two lines from org-agenda.el (patch attached) fixes the problem
(for me).  I am not suggesting this as a patch as it would appear that
an emacs version specific check should probably be made?  I don't know
enough about this to suggest a proper solution unfortunately.

thanks,
eric


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: remove var alias for list-diary-entries-hook --]
[-- Type: text/x-diff, Size: 565 bytes --]

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 28f5429..bdf6881 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4378,8 +4378,6 @@ of what a project is and how to check if it stuck, customize the variable
 
 (defvar org-disable-agenda-to-diary nil)          ;Dynamically-scoped param.
 (defvar diary-list-entries-hook)
-(if (fboundp 'defvaralias)
-    (defvaralias 'diary-list-entries-hook 'list-diary-entries-hook))
 (defvar diary-time-regexp)
 (defun org-get-entries-from-diary (date)
   "Get the (Emacs Calendar) diary entries for DATE."

[-- Attachment #3: Type: text/plain, Size: 131 bytes --]


-- 
: Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.90.1
: using Org-mode version 7.8.03 (release_7.8.03.75.g7e08.dirty)

             reply	other threads:[~2012-01-11  9:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11  8:56 Eric S Fraga [this message]
2012-01-11  9:41 ` [bug] alias for list-diary-entries-hook creates loop in emacs 24 d.tchin
2012-01-11 10:06   ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874nw262hz.fsf@ucl.ac.uk \
    --to=e.fraga@ucl.ac.uk \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).