Org-mode mailing list
 help / color / mirror / Atom feed
* [PATCH] repeat cookies should be in the same order as the repeats
@ 2020-11-04 14:35 Dieter Faulbaum
  2020-11-10  5:49 ` Kyle Meyer
  0 siblings, 1 reply; 3+ messages in thread
From: Dieter Faulbaum @ 2020-11-04 14:35 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Dieter Faulbaum

---
 doc/org-manual.org | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index ef2dad9ef..e78690993 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -5741,6 +5741,7 @@ expressions to process these values before inserting them into a table
 or a dynamic block.
 
 * Dates and Times
+
 :PROPERTIES:
 :DESCRIPTION: Making items useful for planning.
 :END:
@@ -6281,7 +6282,7 @@ organize such tasks using a so-called repeater in a =DEADLINE=,
 the =+1m= is a repeater; the intended interpretation is that the task
 has a deadline on =<2005-10-01>= and repeats itself every (one) month
 starting from that time.  You can use yearly, monthly, weekly, daily
-and hourly repeat cookies by using the =y=, =w=, =m=, =d= and =h=
+and hourly repeat cookies by using the =y=, =m=, =w=, =d= and =h=
 letters.  If you need both a repeater and a special warning period in
 a deadline entry, the repeater should come first and the warning
 period last
-- 
2.28.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] repeat cookies should be in the same order as the repeats
  2020-11-04 14:35 [PATCH] repeat cookies should be in the same order as the repeats Dieter Faulbaum
@ 2020-11-10  5:49 ` Kyle Meyer
  2020-11-20  4:16   ` Kyle Meyer
  0 siblings, 1 reply; 3+ messages in thread
From: Kyle Meyer @ 2020-11-10  5:49 UTC (permalink / raw)
  To: Dieter Faulbaum; +Cc: emacs-orgmode

Thanks for the patch.

> [PATCH] repeat cookies should be in the same order as the repeats

Convention nit: Ideally this subject would start with a "scope/file:",
e.g. "manual:" or "org-manual.org:".

Also, could you please add a changelog entry and TINYCHANGE cookie, as
described at <https://orgmode.org/worg/org-contribute.html>?

Dieter Faulbaum writes:

> ---
>  doc/org-manual.org | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/doc/org-manual.org b/doc/org-manual.org
> index ef2dad9ef..e78690993 100644
> --- a/doc/org-manual.org
> +++ b/doc/org-manual.org
> @@ -5741,6 +5741,7 @@ expressions to process these values before inserting them into a table
>  or a dynamic block.
>  
>  * Dates and Times
> +
>  :PROPERTIES:
>  :DESCRIPTION: Making items useful for planning.
>  :END:

Please drop this unrelated change.

> @@ -6281,7 +6282,7 @@ organize such tasks using a so-called repeater in a =DEADLINE=,
>  the =+1m= is a repeater; the intended interpretation is that the task
>  has a deadline on =<2005-10-01>= and repeats itself every (one) month
>  starting from that time.  You can use yearly, monthly, weekly, daily
> -and hourly repeat cookies by using the =y=, =w=, =m=, =d= and =h=
> +and hourly repeat cookies by using the =y=, =m=, =w=, =d= and =h=
>  letters.  If you need both a repeater and a special warning period in
>  a deadline entry, the repeater should come first and the warning
>  period last

Good catch.  Thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] repeat cookies should be in the same order as the repeats
  2020-11-10  5:49 ` Kyle Meyer
@ 2020-11-20  4:16   ` Kyle Meyer
  0 siblings, 0 replies; 3+ messages in thread
From: Kyle Meyer @ 2020-11-20  4:16 UTC (permalink / raw)
  To: Dieter Faulbaum; +Cc: emacs-orgmode

Kyle Meyer writes:

> Thanks for the patch.
>
>> [PATCH] repeat cookies should be in the same order as the repeats

I've amended the commit (as requested off-list) and pushed (5272d97e5).

Thanks again Dieter.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-20  4:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04 14:35 [PATCH] repeat cookies should be in the same order as the repeats Dieter Faulbaum
2020-11-10  5:49 ` Kyle Meyer
2020-11-20  4:16   ` Kyle Meyer

Org-mode mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://orgmode.org/list/0 list/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 list list/ https://orgmode.org/list \
		emacs-orgmode@gnu.org
	public-inbox-index list

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.orgmode
	nntp://news.gmane.io/gmane.emacs.orgmode


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git