From: Kyle Meyer <kyle@kyleam.com>
To: ian martins <ianxm@jhu.edu>
Cc: Org-Mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] change the ob-java default back to scripting mode
Date: Wed, 28 Oct 2020 21:35:59 -0400 [thread overview]
Message-ID: <878sbpvmo0.fsf@kyleam.com> (raw)
In-Reply-To: <CAC=rjb4CgZQWQBRqJM413FG3KydUVfank-1MQ+KFhE_dmGrRxA@mail.gmail.com>
ian martins writes:
> Subject: [PATCH] ob-java.el: Change the default back to scripting mode
>
> * lisp/ob-java.el: Change the default to scripting mode. Add name to
> authors.
The changelog entry should explicitly list the variables/functions that
are modified. So in this case
* lisp/ob-java.el (org-babel-default-header-args:java): ...
> A recent commit added functional mode and made it default, but this
> would break java source blocks for anyone that relied on the old
> default. This sets the default back to scripting mode.
Thanks for restoring the behavior.
> I missed a name when I put the authors of ob-C and ob-python as the
> authors of ob-java. Added it.
Please move this unrelated change to a separate commit.
next prev parent reply other threads:[~2020-10-29 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 11:50 [PATCH] change the ob-java default back to scripting mode ian martins
2020-10-29 1:35 ` Kyle Meyer [this message]
2020-10-29 8:12 ` ian martins
2020-10-30 4:31 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sbpvmo0.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=ianxm@jhu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).