emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Carlo Tambuatco <oraclmaster@gmail.com>
Cc: Org-Mode Mailing List <emacs-orgmode@gnu.org>,
	Ihor Radchenko <yantar92@posteo.net>
Subject: Re: [BUG] Org 9.6 Inactive timestamp search no longer works as expected.
Date: Sat, 03 Dec 2022 14:49:40 -0500	[thread overview]
Message-ID: <87bkokgtd7.fsf@kyleam.com> (raw)
In-Reply-To: <ED553B84-0209-4097-BCEB-C43698123411@gmail.com>

On 12/03/22 13:44:33 -0500, Carlo Tambuatco wrote:
> Simple inactive timestamp search for recent completed tasks used to return as expected. ie:
>
> +TIMESTAMP_IA>=“<today>”+TIMESTAMP_IA<“<tomorrow>” 
>
> would return all tasks that I completed today. (Had an inactive timestamp greater than or equal 
> to 12:00 am of the current day, but less than tomorrow)
> [...]

Thanks for reporting.  I had noticed one of my "<now>" queries had
stopped working but hadn't yet got around to bisecting.  Doing so now,
this looks like a regression from e022a0cea (org-make-tags-matcher: Do
not treat PROPERTY="[X]" as timestamp match, 2022-10-25).

Ihor, I haven't reviewed the linked discussion in that commit, but with
its change (shown below), the regex now longer matches things like
"<today>" and "<now>".

diff --git a/lisp/org.el b/lisp/org.el
index e93a81210..01e0279c8 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11337,7 +11337,7 @@ (defun org-make-tags-matcher (match &optional only-local-tags)
 			     (pv (match-string 7 term))
 			     (regexp (eq (string-to-char pv) ?{))
 			     (strp (eq (string-to-char pv) ?\"))
-			     (timep (string-match-p "^\"[[<].*[]>]\"$" pv))
+			     (timep (string-match-p "^\"[[<][0-9]+.*[]>]\"$" pv))
 			     (po (org-op-to-function (match-string 6 term)
 						     (if timep 'time strp))))
 			(setq pv (if (or regexp strp) (substring pv 1 -1) pv))



  reply	other threads:[~2022-12-03 19:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-03 18:44 [BUG] Org 9.6 Inactive timestamp search no longer works as expected Carlo Tambuatco
2022-12-03 19:49 ` Kyle Meyer [this message]
2022-12-07 11:26   ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkokgtd7.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=oraclmaster@gmail.com \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).