* [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities
@ 2016-11-04 10:06 Renato Ferreira
2016-11-04 12:45 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Renato Ferreira @ 2016-11-04 10:06 UTC (permalink / raw)
To: emacs-orgmode
When using:
(setq org-agenda-fontify-priorities 'cookies)
(setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67
. "#AC7373") (68 . "#7C4343")))
(org-agenda-fontify-priorities) generates an (:inherit nil ...) face
alist, which ultimately (i can't trace specifically where) causes a lot
of: "Invalid face reference: nil" "Invalid face attribute :inherit nil"
when generating the agenda buffer (when it contains tasks with
priorities).
This issue has been present since 8.3 (and earlier i believe), i've
always patched locally but now i'm using melpa so it would be great if
someone could verify and merge this.
Thanks a lot,
Renato Ferreira
PATCH:
---
org-agenda.el Correct :inherit on org-agenda-fontify-priorities
* Fixes "Invalid face attribute/reference" errors
---
lisp/org-agenda.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 7ee721a..68e82cb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3837,11 +3837,11 @@ FILTER-ALIST is an alist of filters we need to apply when
ov 'face
(let ((special-face
(cond ((org-face-from-face-or-color
- 'priority nil
+ 'priority 'org-priority
(cdr (assoc p org-priority-faces))))
((and (listp org-agenda-fontify-priorities)
(org-face-from-face-or-color
- 'priority nil
+ 'priority 'org-priority
(cdr (assoc p org-agenda-fontify-priorities)))))
((equal p l) 'italic)
((equal p h) 'bold))))
--
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities
2016-11-04 10:06 [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities Renato Ferreira
@ 2016-11-04 12:45 ` Nicolas Goaziou
2016-11-04 12:53 ` Renato Ferreira
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2016-11-04 12:45 UTC (permalink / raw)
To: Renato Ferreira; +Cc: emacs-orgmode
Hello,
Renato Ferreira <renatofdds@gmail.com> writes:
> When using:
> (setq org-agenda-fontify-priorities 'cookies)
> (setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67
> . "#AC7373") (68 . "#7C4343")))
>
> (org-agenda-fontify-priorities) generates an (:inherit nil ...) face
> alist, which ultimately (i can't trace specifically where) causes a lot
> of: "Invalid face reference: nil" "Invalid face attribute :inherit nil"
> when generating the agenda buffer (when it contains tasks with
> priorities).
>
> This issue has been present since 8.3 (and earlier i believe), i've
> always patched locally but now i'm using melpa so it would be great if
> someone could verify and merge this.
Thank you. Could you provide a patch using git format-patch, and tweak
commit message so as to conform to our conventions? E.g.,
Fixes "Invalid face attribute/reference" errors
* lisp/org-agenda.el (org-agenda-fontify-priorities): ...
When using:
(setq org-agenda-fontify-priorities 'cookies)
(setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67
. "#AC7373") (68 . "#7C4343")))
(org-agenda-fontify-priorities) generates an (:inherit nil ...) face
alist, which ultimately (i can't trace specifically where) causes a lot
of: "Invalid face reference: nil" "Invalid face attribute :inherit nil"
when generating the agenda buffer (when it contains tasks with
priorities).
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities
2016-11-04 12:45 ` Nicolas Goaziou
@ 2016-11-04 12:53 ` Renato Ferreira
2016-11-04 15:44 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Renato Ferreira @ 2016-11-04 12:53 UTC (permalink / raw)
To: emacs-orgmode
Fixes "Invalid face attribute/reference" errors
* lisp/org-agenda.el (org-agenda-fontify-priorities): generates correct
:inherit face property.
---
lisp/org-agenda.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 7ee721a..68e82cb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3837,11 +3837,11 @@ FILTER-ALIST is an alist of filters we need to apply when
ov 'face
(let ((special-face
(cond ((org-face-from-face-or-color
- 'priority nil
+ 'priority 'org-priority
(cdr (assoc p org-priority-faces))))
((and (listp org-agenda-fontify-priorities)
(org-face-from-face-or-color
- 'priority nil
+ 'priority 'org-priority
(cdr (assoc p org-agenda-fontify-priorities)))))
((equal p l) 'italic)
((equal p h) 'bold))))
--
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities
2016-11-04 12:53 ` Renato Ferreira
@ 2016-11-04 15:44 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2016-11-04 15:44 UTC (permalink / raw)
To: Renato Ferreira; +Cc: emacs-orgmode
Hello,
Renato Ferreira <renatofdds@gmail.com> writes:
> Fixes "Invalid face attribute/reference" errors
>
> * lisp/org-agenda.el (org-agenda-fontify-priorities): generates correct
> :inherit face property.
>
> ---
> lisp/org-agenda.el | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 7ee721a..68e82cb 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -3837,11 +3837,11 @@ FILTER-ALIST is an alist of filters we need to apply when
> ov 'face
> (let ((special-face
> (cond ((org-face-from-face-or-color
> - 'priority nil
> + 'priority 'org-priority
> (cdr (assoc p org-priority-faces))))
> ((and (listp org-agenda-fontify-priorities)
> (org-face-from-face-or-color
> - 'priority nil
> + 'priority 'org-priority
> (cdr (assoc p org-agenda-fontify-priorities)))))
> ((equal p l) 'italic)
> ((equal p h) 'bold))))
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-04 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04 10:06 [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities Renato Ferreira
2016-11-04 12:45 ` Nicolas Goaziou
2016-11-04 12:53 ` Renato Ferreira
2016-11-04 15:44 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).