From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Marc Ihm <marc@ihm.name>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org.el: make org-open-at-point handle parens in encoded urls correctly
Date: Fri, 11 Aug 2017 18:10:56 +0200 [thread overview]
Message-ID: <87valu5blb.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <omifeu$u6d$1@blaine.gmane.org> (Marc Ihm's message of "Thu, 10 Aug 2017 22:25:05 +0200")
Hello,
Marc Ihm <marc@ihm.name> writes:
> the attached patch changes org-open-at-point in org.el:
>
> Currently, when opening an url the function org-open-at-point uses the
> variable path, which is the result of applying org-link-unescape on
> the original url. Thus, all special chars like '() "' etc. which were
> originally encoded like %20%28 etc. are reverted to their clear text
> form. This worked for me in most cases, but gives me errors when my
> url contains encoded chars like '()', i.e. %28%29.
>
> The submitted patch fixes this by simply using the original url with
> all special chars still encoded.
>
> Please consider applying it, if fit.
Thank you.
The problem here is that Org could introduce additional percent-encoding
upon creating a link. This additional layer needs to be removed before
opening the link.
I think there's a deeper issue to solve here. Your patch is likely to
move the problem elsewhere.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-08-11 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 20:25 [PATCH] lisp/org.el: make org-open-at-point handle parens in encoded urls correctly Marc Ihm
2017-08-11 16:10 ` Nicolas Goaziou [this message]
2017-08-11 18:24 ` Marc Ihm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87valu5blb.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=marc@ihm.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).