emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [bug] org-indent
@ 2017-06-23 10:15 Rasmus
  2017-06-23 11:53 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Rasmus @ 2017-06-23 10:15 UTC (permalink / raw)
  To: emacs-orgmode

Hi,

There's a bug in ‘org-indent--compute-prefixes’ near ";; Inline tasks line
prefixes".

If (bound-and-true-p org-inlinetask-show-first-star) is non-nil, then Org
tries to compute (substring heading-prefix 1).  But the initial value of
‘heading-prefix’ seems to be "", at least some of the time (if
‘indentation’ is 0).  In my Emacs this results in an error. 

Adding an extra check seems to fix it, but I’m not sure if the substring
part is what needs fixing.

	;; Inline tasks line prefixes
	(aset org-indent--inlinetask-line-prefixes
	      n
	      (org-add-props (if (and (bound-and-true-p org-inlinetask-show-first-star)
                                  (org-string-nw-p heading-prefix))
                             (concat org-indent-inlinetask-first-star
                                     (substring heading-prefix 1))
			       heading-prefix)
		  nil 'face 'org-indent)))


Thanks,
Rasmus

-- 
Dung makes an excellent fertilizer

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [bug] org-indent
  2017-06-23 10:15 [bug] org-indent Rasmus
@ 2017-06-23 11:53 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2017-06-23 11:53 UTC (permalink / raw)
  To: Rasmus; +Cc: emacs-orgmode

Hello,

Rasmus <rasmus@gmx.us> writes:

> There's a bug in ‘org-indent--compute-prefixes’ near ";; Inline tasks line
> prefixes".
>
> If (bound-and-true-p org-inlinetask-show-first-star) is non-nil, then Org
> tries to compute (substring heading-prefix 1).  But the initial value of
> ‘heading-prefix’ seems to be "", at least some of the time (if
> ‘indentation’ is 0).  In my Emacs this results in an error.

You're right. I fixed the issue, along with another one, which was
preventing fontification from first star in that case.

Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-23 11:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 10:15 [bug] org-indent Rasmus
2017-06-23 11:53 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).