From: Tim Cross <theophilusx@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix issue with ob-clojure not returning output
Date: Mon, 6 Mar 2017 08:27:12 +1100 [thread overview]
Message-ID: <CAC=50j9YfDydd-yYxipvrnAiR6bjdwnwe3FwRVbJrGU1AY60Yw@mail.gmail.com> (raw)
In-Reply-To: <87fuir7ij0.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
Sure. Commit message
Fix incorrect argument call in ob-clojure.el
org-babel-execute-clojure was calling nrepl-sync-request:eval and
nrepl-request:eval with the session ID as the 3rd argument when the
functions expected a clojure namespace. Replaced (cider-current-session)
with (cider-current-ns).
On 6 March 2017 at 04:14, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Tim Cross <theophilusx@gmail.com> writes:
>
> > The attached patch is a simple fix for the problem with ob-clojure using
> an
> > incorrect cider-current-session call instead of cider-current-ns. For
> > background on the issue see
> > https://emacs.stackexchange.com/questions/30857/clojure-
> code-evaluation-in-org-mode-produces-no-output/31169#31169
>
> Thank you.
>
> Would you mind providing a commit message along with your patch ?
>
> Regards,
>
> --
> Nicolas Goaziou
>
--
regards,
Tim
--
Tim Cross
[-- Attachment #2: Type: text/html, Size: 1856 bytes --]
next prev parent reply other threads:[~2017-03-05 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 4:25 [PATCH] Fix issue with ob-clojure not returning output Tim Cross
2017-03-05 17:14 ` Nicolas Goaziou
2017-03-05 21:27 ` Tim Cross [this message]
2017-03-07 8:10 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC=50j9YfDydd-yYxipvrnAiR6bjdwnwe3FwRVbJrGU1AY60Yw@mail.gmail.com' \
--to=theophilusx@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).