emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Anders Johansson <mejlaandersj@gmail.com>
To: org-mode-email <emacs-orgmode@gnu.org>,
	Ihor Radchenko <yantar92@gmail.com>
Subject: Bug: Changed behaviour of org-at-timestamp-p after recent change
Date: Mon, 11 Apr 2022 13:55:37 +0200	[thread overview]
Message-ID: <CAKJdtO8bqdbW5N6pRFNQRATjm2daEBDCpJj0njwcd4fmhSJSKQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Hi,
I noticed that this commit:
b1a570b3b  org-agenda: Fix regression when diary sexp timestamps are ignored

made a call like (org-at-timestamp-p 'agenda) match against the regexp
`org-element--timestamp-regexp`. However, this regexp doesn’t have the
match groups setup as the others (`org-ts-regexp3` and `org-ts-regexp2`) so
the last part of the docstring for org-at-timestamp-p doesn’t hold anymore
(that the timestamp parts should now be put in match groups).

I was using this in some code of mine, but I also realize that this doesn’t
feel all that clean anyway. I am not sure if this is used elsewhere in org
though.

Best,
Anders

[-- Attachment #2: Type: text/html, Size: 790 bytes --]

             reply	other threads:[~2022-04-11 11:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 11:55 Anders Johansson [this message]
2022-04-15  8:45 ` Bug: Changed behaviour of org-at-timestamp-p after recent change Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKJdtO8bqdbW5N6pRFNQRATjm2daEBDCpJj0njwcd4fmhSJSKQ@mail.gmail.com \
    --to=mejlaandersj@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).