emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: test-org-table/sort-lines: Failing test on macOS
Date: Sun, 20 Nov 2022 15:00:28 +0700	[thread overview]
Message-ID: <tlcmqu$3us$1@ciao.gmane.io> (raw)
In-Reply-To: <87pmdil0m0.fsf@localhost>

On 20/11/2022 11:18, Ihor Radchenko wrote:
>> Max Nikulin writes:
>>>   From my point of view it is a reason to file an Emacs bug because I get
>>>
>>>       (string-collate-lessp "a" "B" "C" t) ; => t
>>
>> See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59275
> 
> According to the discussion on debbugs, it looks like we can use
> `compare-strings' instead. It will be independent of the system locale
> and always follow Unicode rules.
> 
> However, I am not sure if ignoring locale is something we really want.
> WDYT?

I think we should keep `string-collate-lessp' in the 
`org-table-sort-lines' implementation. Users expect sorting accordingly 
to their locales. However it is better to add a warning to 
`org-table-sort-lines' docstring and to the manual that caseless sort 
depends on its implementation in libc, so currently it does not work in 
clang/llvm and so e.g. on MacOS.

Concerning the test, I would split the current testcase into 2 parts 
depending on WITH-CASE argument, check if caseless collation is 
available and skip the related test otherwise.

As to the thread linked to the bug report 
https://lists.gnu.org/archive/html/emacs-devel/2022-07/msg00940.html 
"case-insensitive string comparison." Tue, 19 Jul 2022 13:27:50 -0400, 
there is a link
https://stackoverflow.com/questions/319426/how-do-i-do-a-case-insensitive-string-comparison
unrelated to the issue, but comments and answers there describe a lot of 
pitfalls and explain why string comparison ignoring case is not trivial. 
(It is a Sisyphean task in some sense, I like the comment on 3 sigmas.)



  reply	other threads:[~2022-11-20  8:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 20:15 test-org-table/sort-lines: Failing test on macOS Rudolf Adamkovič
2022-10-07 12:04 ` Max Nikulin
2022-10-08  5:25   ` Ihor Radchenko
2022-10-08 14:27     ` Max Nikulin
2022-10-09  3:59       ` Ihor Radchenko
2022-10-09 15:38         ` Rudolf Adamkovič
2022-10-09 16:53           ` Max Nikulin
2022-10-10 22:25             ` Rudolf Adamkovič
2022-10-12 16:09               ` Max Nikulin
2022-11-15  4:10                 ` Ihor Radchenko
2022-11-20  4:18                   ` Ihor Radchenko
2022-11-20  8:00                     ` Max Nikulin [this message]
2022-11-21  3:15                       ` Ihor Radchenko
2022-11-21 16:48                         ` Max Nikulin
2022-11-22  1:14                           ` Ihor Radchenko
2022-11-22 16:01                             ` Max Nikulin
2022-11-23 10:37                               ` Ihor Radchenko
2022-11-23 15:27                                 ` Max Nikulin
2022-11-23 17:01                                   ` Max Nikulin
2022-11-26  2:05                                   ` Ihor Radchenko
2022-11-29 16:40                                     ` Max Nikulin
2024-04-03 11:40                                       ` [DISCUSSION] Sorting strings in Org mode vs. system locale (was: test-org-table/sort-lines: Failing test on macOS) Ihor Radchenko
2024-05-05 11:59                                         ` Ihor Radchenko
2024-05-07 11:06                                           ` [DISCUSSION] Sorting strings in Org mode vs. system locale Max Nikulin
2024-05-07 13:09                                             ` Ihor Radchenko
2024-05-07 16:47                                               ` Max Nikulin
2024-05-11  9:38                                                 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='tlcmqu$3us$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).