Re: [PATCH] ob-vala.el: Add Vala support to Babel

[Christian Garbs <mitch@cgarbs.de>]

Hello and sorry for the wait!

On Sun, Jul 23, 2017 at 11:05:02AM +0200, Nicolas Goaziou wrote:
> Christian Garbs <mitch@mitch.h.shuttle.de> writes:
> 
> > * ob-vala.el: Add support for the Vala language to Babel.

> > +(defvar org-babel-vala-compiler "valac"
> > +  "Command used to compile a Vala source code file into an
> > +executable.")
> 
> The first line of a docstring should be a full sentence.
> 
> Also, shouldn't this be a defcustom?

Yes, it should.

Looking at the other defcustoms, is the current wording ok?
Or should it still be full a sentence?

> > +(defun org-babel-vala-table-or-string (results)
> > +  "If the results look like a table, then convert them into an
> > +Emacs-lisp table, otherwise return the results as a string."
> > +  )
> 
> The body of the function is missing.

Not only is the body missing, the function is also not used at all, so
I have removed it altogether.  Same for org-babel-vala-var-to-vala.

> Could you send an updated patch?

Incoming :-)

Some of your proposed changes apply to ob-C.el as well.  I could
prepare a different patch for that (under which topic?), but I am not
confident that I could test the changes appropriately.  I don't have
proper C/C++/D org files handy that would cover all cases (eg. header
arguments).

Regards
Christian

PS: My FSF paperwork is complete.
-- 
....Christian.Garbs....................................https://www.cgarbs.de

Wie packt man Styroporkügelchen ein, wenn man sie verschickt?