emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Christian Garbs <mitch@cgarbs.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] ob-vala.el: Add Vala support to Babel
Date: Tue, 01 Aug 2017 23:59:57 +0200	[thread overview]
Message-ID: <87mv7jq78i.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20170801212016.7264C2DB@fluttershy.mitch.h.shuttle.de> (Christian Garbs's message of "Tue, 1 Aug 2017 00:04:34 +0200")

Hello,

Christian Garbs <mitch@cgarbs.de> writes:

> * ob-vala.el: Add support for the Vala language to Babel.
> ---
>  lisp/ob-vala.el | 122 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 122 insertions(+)
>  create mode 100644 lisp/ob-vala.el
>
> diff --git a/lisp/ob-vala.el b/lisp/ob-vala.el
> new file mode 100644
> index 0000000..0375265
> --- /dev/null
> +++ b/lisp/ob-vala.el
> @@ -0,0 +1,122 @@
> +;;; ob-vala.el --- org-babel functions for Vala evaluation

Babel functions for Vala evaluation

Also, could you use lexical binding, i.e., add "-*- lexical-binding:
t; -*-" on the first line of the file and check byte-compilation doesn't
complain.

> +(defcustom org-babel-vala-compiler "valac"
> +  "Command used to compile a C source code file into an executable.
> +May be either a command in the path, like `valac'

like \"valac\"

> +or an absolute path name, like `/usr/local/bin/valac'.

an absolute file name, like \"/usr/local/bin/valac\".

> +Parameters may be used like this: `valac -v'"

like this: \"valac -c\""

> +  :group 'org-babel
> +  :version "24.3"
> +  :type 'string)

Some keywords are missing:

  :version "26.1"
  :package-version '(Org . "9.1")

Barring the suggestions above, your patch looks good. I think we can
apply it as soon as the FSF process is complete.

Thank you!

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2017-08-01 22:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-09 20:09 Babel support for Vala Christian Garbs
2017-07-10  9:03 ` Nicolas Goaziou
2017-07-10 17:54   ` Christian Garbs
2017-07-11  8:10     ` Nicolas Goaziou
2017-07-13 21:42       ` Christian Garbs
2017-07-14  8:30         ` Nicolas Goaziou
2017-07-14 19:43           ` [PATCH] ob-vala.el: Add Vala support to Babel Christian Garbs
2017-07-23  9:05             ` Nicolas Goaziou
2017-07-31 22:04               ` [PATCH v2] " Christian Garbs
2017-08-01 21:59                 ` Nicolas Goaziou [this message]
2017-07-31 22:04                   ` [PATCH v3] " Christian Garbs
2017-08-07  9:41                     ` Nicolas Goaziou
2017-08-01 21:20               ` [PATCH] " Christian Garbs
2017-08-01 22:03                 ` Nicolas Goaziou
2017-08-02 20:24                   ` Christian Garbs
2017-08-03 10:49                     ` Nicolas Goaziou
2017-08-05 19:53                       ` Christian Garbs
2017-08-06  0:22                         ` Nicolas Goaziou
2017-08-06 10:06                           ` Christian Garbs
2017-08-07  9:52                             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv7jq78i.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=mitch@cgarbs.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).