emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Henrik Frisk <frisk.h@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Jonathan Gregory <jgrg@autistici.org>,
	"Dr. Arne Babenhauserheide" <arne_bab@web.de>,
	 "Victor A. Stoichita" <victor@svictor.net>,
	emacs-orgmode@gnu.org
Subject: Re: [BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?)
Date: Tue, 15 Aug 2023 09:33:54 +0200	[thread overview]
Message-ID: <CAO0LSb4Y1qO49eRE__e57OAJU7w2h_thztc69RSw-+rWuRcy-g@mail.gmail.com> (raw)
In-Reply-To: <87y1iit5z9.fsf@localhost>

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

Den fre 11 aug. 2023 kl 09:04 skrev Ihor Radchenko <yantar92@posteo.net>:

> Jonathan Gregory <jgrg@autistici.org> writes:
>
> >> Jonathan, do you think that your original patch is still what
> >> you want to get merged?
> >
> > Yes, the one I sent on 20 Jul 2023. I haven't had any issues with
> > it so far.
>
> Ok. Would you mind adding a commit message, as described in
> https://orgmode.org/worg/org-contribute.html#first-patch?
>
> And do I understand correctly that no changes in
> https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html
> are needed?
>
> Sorry for being late in this discussion. As a user of ob-lilypond I'm very
happy about these changes. On my last install, as well as my current I have
had to change the following:

(org-babel-get-header params :var) which appears to be outdated, to:

(org-babel--get-vars params)

in the version of ob-lilypond.el from here:
https://github.com/mjago/ob-lilypond/blob/master/lisp/ob-lilypond.el. Which
version of the file are you patching now?

Another request would be to have the variables ly-XXX-pdf-path and
ly-XXX-midi-path settable, or, perhaps, read from the lilypond settings of
corresponding variables. I'm not an elisp programmer but I could look into
that if it's of interest.

/Henrik

[-- Attachment #2: Type: text/html, Size: 2180 bytes --]

  reply	other threads:[~2023-08-15  7:35 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 15:13 Moving some lisp/ob-*.el files to org-contrib - your advice? Bastien
2021-05-03 17:49 ` Timothy
2021-05-03 18:05   ` Bastien
2021-05-03 19:36     ` Palak Mathur
2021-05-03 19:44       ` Timothy
2021-05-03 19:47         ` Palak Mathur
2021-05-03 20:34         ` Bastien
2021-05-03 20:33       ` Bastien
2021-05-04  7:55   ` Eric S Fraga
2021-05-19  3:36     ` Jack Kamm
2021-05-03 20:52 ` Victor A. Stoichita
2021-05-04 10:19   ` Dr. Arne Babenhauserheide
2021-05-04 11:28     ` Bastien
2021-05-04 18:38       ` Victor A. Stoichita
2023-07-12 13:40     ` [BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?) Ihor Radchenko
2023-07-12 22:35       ` Jonathan Gregory
2023-07-13  6:52         ` Dr. Arne Babenhauserheide
2023-07-13 10:08         ` Ihor Radchenko
2023-07-13 11:04           ` Jonathan Gregory
2023-07-14 12:38           ` Jonathan Gregory
2023-07-14 13:15             ` Dr. Arne Babenhauserheide
2023-07-14 13:52               ` Ihor Radchenko
2023-07-14 18:06             ` Ihor Radchenko
2023-07-17 17:02               ` Jonathan Gregory
2023-07-18  9:38                 ` Ihor Radchenko
2023-07-19 12:17                   ` Jonathan Gregory
2023-07-20  7:13                     ` Ihor Radchenko
2023-07-20 17:53                       ` Jonathan Gregory
2023-07-21  7:36                         ` Ihor Radchenko
2023-07-21 11:38                           ` Jonathan Gregory
2023-07-22  8:12                             ` Ihor Radchenko
2023-07-25 16:16                               ` Henrik Frisk
2023-07-25 16:26                                 ` Henrik Frisk
2023-07-25 17:17                                   ` Jonathan Gregory
2023-07-25 21:40                                     ` Henrik Frisk
2023-07-25 17:29                               ` Jonathan Gregory
2023-07-26  8:15                                 ` Ihor Radchenko
2023-07-26 12:35                                   ` Jonathan Gregory
2023-07-27  7:21                                     ` Ihor Radchenko
2023-07-27 12:42                                       ` Jonathan Gregory
2023-07-28  7:37                                         ` Ihor Radchenko
2023-07-28 14:02                                           ` Jonathan Gregory
2023-07-29  7:16                                             ` Ihor Radchenko
2023-07-31 11:14                                               ` Jonathan Gregory
2023-07-31 11:58                                                 ` Ihor Radchenko
2023-07-31 12:42                                                   ` Jonathan Gregory
2023-08-08 13:01                                                     ` Ihor Radchenko
2023-08-10 11:05                                                       ` Jonathan Gregory
2023-08-11  7:04                                                         ` Ihor Radchenko
2023-08-15  7:33                                                           ` Henrik Frisk [this message]
2023-08-15 10:41                                                             ` Ihor Radchenko
2023-08-15 15:57                                                               ` Henrik Frisk
2023-08-15 16:04                                                                 ` Ihor Radchenko
2023-08-16 12:54                                                           ` Jonathan Gregory
2023-08-17 10:26                                                             ` Ihor Radchenko
2023-08-19 12:56                                                           ` Jonathan Gregory
2023-08-20  7:20                                                             ` Ihor Radchenko
2023-08-20 12:47                                                               ` Jonathan Gregory
2023-08-20 13:46                                                                 ` Dr. Arne Babenhauserheide
2023-08-21  7:48                                                                 ` Ihor Radchenko
2023-07-13  6:33       ` [BUG] WORG example for ob-lilypond is no longer working as described Dr. Arne Babenhauserheide
2023-07-13  7:03         ` Dr. Arne Babenhauserheide
2023-07-13  8:03         ` Jean Abou Samra
2023-07-16 12:21           ` Graham King
2023-07-16 12:30             ` Ihor Radchenko
2021-05-04 11:32   ` Moving some lisp/ob-*.el files to org-contrib - your advice? Bastien
2021-05-03 22:19 ` Tim Cross
2021-05-03 23:15   ` Bastien
2021-05-04 10:19 ` Dr. Arne Babenhauserheide
2021-05-04 11:10   ` Bastien
2021-09-26  8:17   ` Bastien
2021-05-06  9:19 ` Jean Louis
2021-05-06  9:39   ` Bastien
2021-05-14 18:23 ` Greg Minshall
2021-05-17 16:39   ` Greg Minshall
2021-09-26 12:50 ` Bastien Guerry
2021-10-02 17:11 ` Bastien Guerry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAO0LSb4Y1qO49eRE__e57OAJU7w2h_thztc69RSw-+rWuRcy-g@mail.gmail.com \
    --to=frisk.h@gmail.com \
    --cc=arne_bab@web.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=jgrg@autistici.org \
    --cc=victor@svictor.net \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).